Skip to content

Add top-level site and cross site ancestry to storage key #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kyraseevers
Copy link

@kyraseevers kyraseevers commented Jun 20, 2025

Add top-level site and cross-site ancestry to Storage Key in the Storage spec.

This is taking over #144, and should be landed with or after the "cross site ancestry" is added to the environment in whatwg/html/pull/11133.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me modulo some minor nits. Thanks again for tackling it!

You can consider WebKit interested.

What's remaining:

  1. Filing bugs against Gecko and WebKit and linking them from OP.
  2. You can mark the MDN checkbox and say N/A.
  3. Have you checked whether all the dependencies of this specification are holding the storage key correctly or are any doing something special with the origin field, for instance?
  4. Is there a PR to rename the tests away from .tentative? (Assuming that there's nothing further that needs updating in the relevant specifications.)
  5. The HTML PR needs to land first. I haven't really checked what's blocking that one yet.

cc @asutherland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants