Add popover attribute

[josepharhar]

Feature proposal issue: #7785
Explainer: https://open-ui.org/components/popup.research.explainer

• At least two implementers are interested (and none opposed):
  • Chrome
  • Firefox: The Popover API mozilla/standards-positions#698
  • Safari: The Popover API WebKit/standards-positions#74
• Tests are written and can be reviewed and commented upon at:
  • https://wpt.fyi/results/html/semantics/popups
• Implementation bugs are filed:
  • Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1307772
  • Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1808823
  • Safari: https://bugs.webkit.org/show_bug.cgi?id=250171

---

/browsers.html ( diff )
/dnd.html ( diff )
/dom.html ( diff )
/form-elements.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/rendering.html ( diff )
/semantics-other.html ( diff )
/webappapis.html ( diff )
/popover.html ( diff )

[josepharhar]

I see that there are many build errors after build.sh says "Running conformance checker...", but when I run build.sh locally, it just stops after "Success!".

How do I run the conformance checker when building locally?

[domenic]

The conformance checker is at https://github.com/validator/validator and has a variety of installation options. You need to run it on the output index.html file.

[josepharhar]

The conformance checker is at https://github.com/validator/validator and has a variety of installation options. You need to run it on the output index.html file.

Thanks, I was able to run it! It looks like the PR builds now

[josepharhar]

@domenic I added some examples in 81acbc7 and 9e0421c. Can you point me to any examples of "descriptive text for web developers and for implementers" that you mentioned earlier?

[domenic]

I managed to get a start on this review today... still more to go, but hopefully this helps.

[josepharhar]

Thanks for the review! I'm going to be out until monday so I'll try to get to it then

[josepharhar]

Thanks for the review @domenic! I have addressed all your comments

[Kaiido]

Not an authoritative review; but some questions that popped up while quickly reading the PR.

[josepharhar]

@domenic mind taking another look? Anything else I can do to help move this forward?

[domenic]

It's on my list, sorry! I had a week of TPAC then a week of vacation, so I'm currently down to 20 flagged work emails and 24 flagged GitHub emails :).

[annevk]

Drive-by: element and attribute indices haven't been updated as far as I can tell. (FWIW, I plan on doing a more careful review.)

[domenic]

Lots of editorial issues; as always, if you can be sure to do an extra sweep to make sure you catch multiple instances, that saves a lot of time.

On normative issues, I think these are the biggest outstanding ones:

• show/hide naming (under discussion in Open UI I guess, not sure how that's going)
• Element vs. HTMLElement; i.e., behavior for unknown, SVG, and MathML elements
• Some confusion about spec text for some animation pausing stuff
• Light dismiss spec intercepting capture events on Document is quite unusual; @annevk's help there would be appreciated steering us in the right direction

[josepharhar]

show/hide naming (under discussion in Open UI I guess, not sure how that's going)

Looks like we might rename them to popupshow and popuphide: openui/open-ui#607

Element vs. HTMLElement; i.e., behavior for unknown, SVG, and MathML elements

@mfreed7 Why did you implement all of the popup behavior in Element instead of HTMLElement? What do you think the behavior should be for unknown, SVG, and MathML elements?

[mfreed7]

@mfreed7 Why did you implement all of the popup behavior in Element instead of HTMLElement? What do you think the behavior should be for unknown, SVG, and MathML elements?

My general logic has been "why not?". I.e. we had the same debate in the TAG about limiting this feature to only some element types. And if there's a good reason to limit it, great. But if the only reason is that we don't know what it'll be used for, I think web developers will figure that out. For example, why not a pop-up SVG? I could think of some use cases where an icon (a "like button" for example) is made with SVG and would like to be a pop-up.

Side note: this is currently broken in Chromium, but pending this discussion, I'll fix that. Just a missing set of rules in the UA stylesheet.