fix(tempo): bump ox to 0.14.18 so bundled UI preserves limits[].period#393
Open
fix(tempo): bump ox to 0.14.18 so bundled UI preserves limits[].period#393
Conversation
The Tempo payment bundle's KeyAuthorization serializer was running ox 0.14.7 (forced by the workspace override), which predates the period field. Per-period access keys signed off-chain with a period digest were re-encoded without it before submission, so the chain couldn't recover the signer and silent signing fell back to the wallet approval dialog. Aligning both ox declarations on 0.14.18: - pnpm-workspace.yaml: override 0.14.7 → 0.14.18 - package.json: 0.14.15 → 0.14.18 The override and the main package have been silently disagreeing since ox started moving forward without the override being bumped along; this also fixes that drift. Tested locally with mpp-playground: silent signing on payment-link pages now succeeds for keys with a per-period limit. Type checks pass on both the main package and the html bundle subpackages.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
|
LGTM -- thank you! |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #392.
The Tempo payment bundle's
KeyAuthorizationserializer was runningox 0.14.7(forced by the workspace override), which predates theperiodfield. Per-period access keys signed off-chain with a digest that includedperiodwere re-encoded without it before chain submission, so signer recovery failed:Silent signing then fell back to the wallet approval dialog.
What changed
Aligned both
oxdeclarations on0.14.18:pnpm-workspace.yaml: override0.14.7→0.14.18package.json:0.14.15→0.14.18Verified locally
pnpm check:typespasses for the main packagepnpm check:types:htmlpasses for the bundle subpackagesNotes
accountsinsrc/tempo/server/internal/html/package.jsonis unchanged. Bumping it is unrelated to this bug and would carry the dialog-host migration as separate scope.