Fix dynamic parameter regex replacement in processComplexMatch
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replace failed to inject the route parameter as the layer regex was changed from `/^\/(?:([^\/]+?))\/?(?=\/|$)/i` to `/^(?:\/([^/]+?))\/?(?=\/|$)/i`. Now both regex cases are taken into consideration. The regex was changed to use optional non-capturing groups for the differences between the two possible regex patterns. Link to playground using the new regex format: https://regex101.com/r/cursDu/1
erikjuhani
force-pushed
the
fix-routes-in-a-different-file-test
branch
from
4280f48 to
2bdd2fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again @wesleytodd! 👋
One test case was failing as mentioned in my other pr #64. This should fix that issue!
The replace failed to inject the route parameter as the layer regex was changed from
/^\/(?:([^\/]+?))\/?(?=\/|$)/ito/^(?:\/([^/]+?))\/?(?=\/|$)/i.Now both regex cases are taken into consideration. The regex was changed to use optional non-capturing groups for the differences between the two possible regex patterns.
Link to playground using the new regex format: https://regex101.com/r/cursDu/1