Skip to content

Fix available property for nic.cl and dns.pt #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sofia-bahamonde wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −4
Draft

Fix available property for nic.cl and dns.pt #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5809f86
debugging
Mar 2, 2023
e7c4eda
fix nic.cl and dnd.pt available methods
Mar 2, 2023
9cfe6e4
remove end of string match
Mar 2, 2023
7eb9013
fix specs
Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/whois/parsers/whois.dns.pt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class WhoisDnsPt < Base
end

property_supported :available? do
!!(content_for_scanner =~ /^.* no match$/)
!!(content_for_scanner =~ /^.* No Match/)
end

property_supported :registered? do
Expand Down
2 changes: 1 addition & 1 deletion lib/whois/parsers/whois.nic.cl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class WhoisNicCl < Base
end

property_supported :available? do
!!(content_for_scanner =~ /^(.+?): no existe$/)
!!(content_for_scanner =~ /^(.+?): no entries found/)
end

property_supported :registered? do
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/responses/whois.dns.pt/pt/status_available.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
u34jedzcq.pt no match
u34jedzcq.pt - No Match\n
2 changes: 1 addition & 1 deletion spec/fixtures/responses/whois.nic.cl/cl/status_available.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
u34jedzcq.cl: no existe
%%\n%% This is the NIC Chile Whois server (whois.nic.cl).\n%%\n%% Rights restricted by copyright.\n%% See https://www.nic.cl/normativa/politica-publicacion-de-datos-cl.pdf\n%%\n\u34jedzcq.cl: no entries found.\n\n