Skip to content

build: bump minimum ruby version to 3.1.0 and fix various errors. #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

build: bump minimum ruby version to 3.1.0 and fix various errors. #682

wants to merge 10 commits into from
+133 −30

Conversation

@AlextheYounga
Copy link

@AlextheYounga AlextheYounga commented Nov 13, 2025 •
edited
Loading

Ruby 2.6 is well past end-of-life and trying to support it means untangling a lot of brittle shims. Ruby 3.0 also reached EOL in April 2024, so requiring it would still leave you relying on an unsupported interpreter almost immediately.

Changes:

  • Raised the minimum Ruby to 3.1 across wordmove.gemspec, CI config, and .ruby-version, resolving Psych 4 keyword‑arg issues (lib/wordmove/movefile.rb:25). Updated RuboCop config and formatting accordingly so lint/test suites still pass on the new baseline.
  • Hardened wordmove doctor: rsync checks now detect GNU rsync and macOS/Homebrew openrsync (lib/wordmove/doctor/rsync.rb:10-23), plus accompanying specs (spec/doctor/rsync_spec.rb:1-60). Doctor CLI now rescues missing/invalid Movefiles and prints user-friendly errors instead of stack traces (lib/wordmove/cli.rb:15-24, spec/cli_spec.rb:19-55).
  • Added regression coverage for the new behaviors and ensured the full test/lint suite stays green under Ruby 3.1.
  • Fixes errors found in Error with Wordmove: uninitialized constant Logger (NameError) after updating macOS to 15.2 #675 and Crash Ruby 3.1.1 #673

Potentially effects (or corrects) #679

All tests pass and some new tests were added.
I keep clean commits. Please see each commit to see each individual change.

@AlextheYounga
build: bump ruby version to sweet spot 3.1.0
477e36b
@AlextheYounga
chore: update rubocop yaml with disable cops
c8dddb0
@AlextheYounga
refactor: move constant to top of file
4e4e34d
@AlextheYounga
fix: correct error due to logger loading order
d32b5dd 
This change corrects an error due to bumping the Ruby version higher
as newer Ruby versions load logger in a different order. You get
uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
errors in 3.1
@AlextheYounga
fix: correct error in wordmove doctor regarding rsync
14a6fae 
This change corrects an error in wordmove doctor
'Wordmove::Doctor::Rsync#check!': undefined method '[]'
for nil (NoMethodError).
@AlextheYounga
fix: correct error due to ruby 3 rewrite of psych 4
131145e 
This change corrects an ArgumentError that arises from passing in
now obsolete arguments into YAML safeload.
@AlextheYounga
chore: please the cop
cafd9f6 
This change just adds minor string concatenation changes and regex
formatting changes in order to please the pig.
@AlextheYounga
feat: wordmove doctor checks for macos rsync
75ce300
@AlextheYounga
feat: add pretty error when running doctor without movefile
87943ad
@AlextheYounga AlextheYounga mentioned this pull request Nov 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlextheYounga