Add stat row for leagues thorns/recoil damage#855
Open
Gorzoid wants to merge 10 commits intoweirdgloop:mainfrom
Open
Add stat row for leagues thorns/recoil damage#855Gorzoid wants to merge 10 commits intoweirdgloop:mainfrom
Gorzoid wants to merge 10 commits intoweirdgloop:mainfrom
Conversation
Since we have a good signal for whether user cares about recoil (selected relic or set incoming damage) we don't need to hide below "Show more"
- Use BULWARK category for shield - Add Elidinis' ward to list of shields (its not in wiki list but wik calls it a magical shield, it looks like a shield, and if Arcane Spirit Shield is a shield then so must fortified ward)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new stat row to help calculate expected recoil damage with leagues talents. Row is only shown if there is some recoil damage is non-zero.
For thorns damage calculation is trivial as it does not vary with damage / accuracy. For rest of damage we allow user to input an expected damage, this ends up being more useful than trying to use the limited NPC vs Player damage calc.