Add the ability to filter monsters#576
Open
coopermor wants to merge 1 commit intoweirdgloop:mainfrom
Open
Conversation
Member
|
Hey, thanks! I'll try and get around to reviewing this within the next couple of weeks. |
jayktaylor
approved these changes
May 19, 2025
Member
jayktaylor
left a comment
There was a problem hiding this comment.
This looks good to me, it's probably a good idea to also add the check you mentioned before to ensure that we're not removing anything that has differing stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to filter monsters in the selection through the use of aliases similar to equipment. This is useful as there are many monsters with a plethora of cosmetic variants. Some of the worst offenders are Zombie pirate (Harmony Island) with 26 cosmetic variants or Jelly with 10 cosmetic variants.
In my opinion this is an improvement to the user experience.
Before:


After:
I'm curious thoughts on the tests. If you like them I can add more. If you don't think they have a value they can be removed. My thought is monsters like Blue dragon#1 could get merged with Blue dragon#Ruins of Tapoyauik, 1 if an error is introduced in the regex. This would be an issue as they do not have the same elemental weakness.
In my first implementation I added a function to determine if a monster is a cosmetic variant. If you would like to see that as a second safeguard after the regex I would be happy to include that.