Skip to content

fix ~10x performance regression by reverting a change#337

Merged
weichsel merged 1 commit intoweichsel:developmentfrom
TechSmith:performanceImprovements
Nov 27, 2025
Merged

fix ~10x performance regression by reverting a change#337
weichsel merged 1 commit intoweichsel:developmentfrom
TechSmith:performanceImprovements

Conversation

@LGriffioen
Copy link
Copy Markdown
Contributor

@LGriffioen LGriffioen commented Sep 6, 2024

change was introduced with zip64 support

Fixes #311

Changes proposed in this PR

Tests performed

  • performance of loading 10,000 files that are zipped is ~10x faster than development, and roughly where it was before the Zip64 changes
  • I'm not familiar enough with Zip64 to be able to test what impacts this change has on that functionality

Further info for the reviewer

  • Performance with large numbers of files is critical for us. This 10x improvement is taking a 20s operation down to under 2s

Open Issues

change was introduced with zip64 support
@LGriffioen LGriffioen force-pushed the performanceImprovements branch from 88c63ad to a80379b Compare November 25, 2025 21:47
@LGriffioen
Copy link
Copy Markdown
Contributor Author

@weichsel @Ckitakishi i just rebased this, any chance either of you could take a look? thanks!

@weichsel
Copy link
Copy Markdown
Owner

Thanks for keeping this up to date.
I checked the changes, and they look good. They follow the ZIP specification, and since they only affect parsing of the standard EOCD record, there shouldn’t be any side effects or regressions related to ZIP64 support. This should also address the overall EOCD parsing performance regression. 🙏

@weichsel weichsel merged commit 3f21a90 into weichsel:development Nov 27, 2025
10 checks passed
@LGriffioen
Copy link
Copy Markdown
Contributor Author

thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance regression when opening lots of zip archives

2 participants