fix: PeX never sending local peers to remote peers #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start PeX timer by calling ut_pex.start() after wire.use(utPex()) - Share existing wire peers with new PeX instances to enable peer exchange - Add comprehensive tests for PeX functionality Fixes webtorrent#2919
|
🙌 Thanks for opening this pull request! You're awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixed PeX (Peer Exchange) functionality to properly send local peers to remote peers. The issue was that
ut_pex.start()was never called and existing wire peers weren't shared with new PeX instances.Changes made:
ut_pex.start()afterwire.use(utPex())to start the PeX message timertest/node/pex.jsto verify functionalityWhich issue (if any) does this pull request address?
Fixes #2919
Is there anything you'd like reviewers to focus on?
Please review:
lib/torrent.js- ensuring existing wires are properly shared with new PeX instancesut_pex.start()call placement and timingtest/node/pex.js- verifies timer starts, peer sharing works, and cleanup is proper