chore(deps): bump jsdom from 28.0.0 to 29.1.1#158
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
7345d1b to
09c9b60
Compare
There was a problem hiding this comment.
Mogplex PR Review
Status: Attention needed
Routine devDependency bump for jsdom (28.0.0 → 29.1.1). No security or correctness issues found. Two warnings: new transitive dependencies raise the effective Node.js floor to 20.19.0, and jsdom v29's CSSOM overhaul warrants test validation before merge.
1 finding was added inline.
Warnings
- New transitive dependencies require Node.js ^20.19.0 (pnpm-lock.yaml)
New transitive dependencies introduced by this bump—@asamuzakjp/css-color@5.1.11,@asamuzakjp/dom-selector@7.1.1, and@asamuzakjp/generational-cache@1.0.1—declareengines: {node: ^20.19.0 || ^22.12.0 || >=24.0.0}. The project has no.nvmrcorenginesfield inpackage.json, so there is no documented Node version floor. Developers running Node 20.18 or earlier will hit engine mismatch warnings from pnpm.
| "eslint-config-next": "16.2.3", | ||
| "husky": "^9.1.7", | ||
| "jsdom": "^28.0.0", | ||
| "jsdom": "^29.1.1", |
There was a problem hiding this comment.
Warning: Major jsdom version includes CSSOM overhaul — validate tests
jsdom v29 includes a major CSSOM implementation overhaul—replacing @acemir/cssom and cssstyle with fresh internal implementations built on css-tree. This affects getComputedStyle(), shorthand parsing, and style mutation behavior. Since this project uses environment: "jsdom" in Vitest, any tests relying on computed styles or CSSOM edge cases could fail silently or produce different results.
855361e to
803c358
Compare
Bumps [jsdom](https://github.com/jsdom/jsdom) from 28.0.0 to 29.1.1. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v28.0.0...v29.1.1) --- updated-dependencies: - dependency-name: jsdom dependency-version: 29.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
803c358 to
79c3c16
Compare
|
Closing: jsdom@29 breaks the Vitest forks pool — every worker fails to start with |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps jsdom from 28.0.0 to 29.1.1.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
9b9ea7e29.1.107efb78Optimize computed style comparison5f66329Fix background-origin/background-clip in background shorthandad8af77Fix border shorthand handling5a3e88e29.1.073db204Update dependencies and dev dependenciesa7168a5Support ratio CSS unit type15346e0Fix style cache invalidation2a1e2cd29.0.24097d66Resolve computed CSS values lazily in CSSStyleDeclarationMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for jsdom since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.