-
Notifications
You must be signed in to change notification settings - Fork 0
docs: address extend-section review findings #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ Together they cover the same capability surface the [MCP server](/extend/mcp-ser | |
|
|
||
| ## Why this is the right path today | ||
|
|
||
| - **No pasted tokens.** The `mogplex login` browser flow owns the credential and writes it to the OS keyring. The external agent never sees raw auth material. | ||
| - **No pasted tokens.** The `mogplex login` browser flow owns the credential and writes it to `~/.mogplex/auth.json` — see the [Authentication guide](/cli/guides/authentication) for precedence rules and file contents. The external agent never sees raw auth material. | ||
| - **Works in every skill-aware host.** The skill format is portable: Claude Code, Claude Agent SDK, and any host that reads `SKILL.md`-style files. Cursor project rules work too by copying the skill body. | ||
| - **Thin wrapper.** Skills do not duplicate Mogplex logic — they are instructions for how to call the existing CLI, which calls the existing Mogplex runtime. | ||
| - **No infra dependency.** Ships the moment the CLI is on the user's `PATH`. Nothing to deploy, no tokens to provision. | ||
|
|
@@ -33,7 +33,7 @@ Together they cover the same capability surface the [MCP server](/extend/mcp-ser | |
| | --- | --- | --- | | ||
| | Status | **Available** | Preview design; not live | | ||
| | Protocol | Skill file + shell | MCP Streamable HTTP | | ||
| | Auth | `mogplex login` → OS keyring | OAuth 2.1 + PKCE (DCR) | | ||
| | Auth | `mogplex login` → `~/.mogplex/auth.json` | OAuth 2.1 + PKCE (DCR) | | ||
| | Token pasted in config? | No | No | | ||
| | Execution path | External agent shells out to `mogplex exec` | External agent calls MCP tool | | ||
| | Streaming progress | `--jsonl` | MCP `notifications/progress` | | ||
|
|
@@ -44,8 +44,22 @@ When the MCP server ships, both paths will stay supported. Skills will continue | |
|
|
||
| ## Install | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: Option A ( In |
||
|
|
||
| First fetch the skill files from [`webrenew/mogplex-docs`](https://github.com/webrenew/mogplex-docs). Either clone the repo or download the `skills/` tree directly: | ||
|
|
||
| ```bash | ||
| # Option A — clone and cd | ||
| git clone https://github.com/webrenew/mogplex-docs.git | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Broken shell command: In npx -y degit webrenew/mogplex-docs/skills mogplex-skills
cd mogplex-skills && cd .. # or rename the dir as you likeThe The Option A path ( # Option B — sparse download of just the skills/ tree
npx -y degit webrenew/mogplex-docs/skills mogplex-skills
# The directory is now ready; see copy commands below — run them from the parent, not inside mogplex-skillsThen change the copy block to reference |
||
| cd mogplex-docs | ||
|
|
||
| # Option B — sparse download of just the skills/ tree | ||
| npx -y degit webrenew/mogplex-docs/skills mogplex-skills | ||
| cd mogplex-skills && cd .. # or rename the dir as you like | ||
|
Comment on lines
+55
to
+56
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If a reader follows Option B ( Useful? React with 👍 / 👎. |
||
| ``` | ||
|
|
||
| Then copy the `skills/` contents into your agent host: | ||
|
|
||
| ```bash | ||
| # Global (Claude Code) | ||
| # Global (Claude Code) — run from the directory containing `skills/` | ||
| mkdir -p ~/.claude/skills && cp -R skills/* ~/.claude/skills/ | ||
|
|
||
| # Or per-project | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: Install instructions are inconsistent between
extend/skills.mdxandcli/skills/index.mdxThe two pages address the same install task but diverge in a way that will confuse readers who visit both:
extend/skills.mdx(Option B) downloads tomogplex-skills/, then the subsequent copy block usescp -R skills/* ~/.claude/skills/— which requires the user to be inside a directory that contains askills/subdirectory. Afterdegit, no such subdirectory exists;mogplex-skills/is the skills tree.cli/skills/index.mdx(Claude Code block) correctly usescp -R . ~/.claude/skills/aftercd mogplex-skills, acknowledging that the current directory is the skills tree.For the per-project case in
cli/skills/index.mdx, the snippet usescp -R /path/to/mogplex-skills/* .claude/skills/with a hardcoded placeholder path, which is less helpful than a relative path or an explicit note to replace it. Consider aligning both pages to the same download-then-copy pattern and making sure the glob targets are consistent.