Skip to content

Add date range support to access control rules #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Jul 31, 2025

Description

Fixes #703

This PR adds date range support to ACL rules that uses the existing embargo syntax.

Access can be controlled by specifying before or after a particular timestamp, e.g.

org,iana)/ - {"access": "allow", "url": "http://www.iana.org/", "before": "20140126"}

Time intervals can also be used via newer and older, e.g.:

org,iana)/ - {"access": "allow", "url": "http://www.iana.org/", "newer": {"years": 1, "months": 6}}

Documentation has also been added.

Motivation and Context

This will allow users to block/allow a subset of captures from a URL based on date, e.g. in the case where ownership of a URL changed at some point.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l tw4l force-pushed the issue-703-acl-dates branch from c7432ad to 44ee362 Compare July 31, 2025 20:32
@tw4l tw4l changed the title Work in progress: Add support for before and after timestamps to ACL access rules Work in progress: Add date support to ACL access rules Jul 31, 2025
@tw4l tw4l changed the title Work in progress: Add date support to ACL access rules Add date range support to access control rules Jul 31, 2025
@tw4l tw4l marked this pull request as ready for review July 31, 2025 20:36
@tw4l tw4l requested a review from ikreymer July 31, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add date ranges to access control lists
1 participant