-
-
Notifications
You must be signed in to change notification settings - Fork 55
Add "shareable" notices to workflow list & detail #2788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
emma-sg
merged 6 commits into
issue-2762-shareable-workflow
from
issue-2762-shareable-workflows--frontend
Aug 18, 2025
Merged
Add "shareable" notices to workflow list & detail #2788
emma-sg
merged 6 commits into
issue-2762-shareable-workflow
from
issue-2762-shareable-workflows--frontend
Aug 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-sg
commented
Jul 31, 2025
SuaYoo
reviewed
Aug 14, 2025
frontend/src/features/crawl-workflows/templates/shareable-notice.ts
Outdated
Show resolved
Hide resolved
SuaYoo
approved these changes
Aug 14, 2025
@tw4l do you have a preference between merging this into the backend pr or keeping them separate? |
Fine by me either way! |
We can merge it into one branch to make it easier to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2785
To be rebased after #2783 is merged, or merged into it
Changes
<btrix-badge>
component to pass throughclass
prop into internal element (allows for deeper customization)Manual testing
shareable
set totrue
Screenshots