chore: migrate to eslint-config-webpack

.editorconfig

@@ -14,3 +14,6 @@ indent_size = 2
 
 [*.md]
 trim_trailing_whitespace = false
+
+[*.snap]
+trim_trailing_whitespace = false

.github/workflows/test.yml

@@ -48,6 +48,10 @@ jobs:
           cache: yarn
       - name: Install dependencies
         run: yarn --frozen-lockfile --ignore-engines
+        if: matrix.node-version == '6.x' || matrix.node-version == '8.x' || matrix.node-version == '10.x' || matrix.node-version == '12.x' || matrix.node-version == '14.x' || matrix.node-version == '16.x'
+      - name: Install dependencies
+        run: yarn --frozen-lockfile
+        if: matrix.node-version != '6.x' && matrix.node-version != '8.x' && matrix.node-version != '10.x' && matrix.node-version != '12.x' && matrix.node-version != '14.x' && matrix.node-version != '16.x'
       - name: Run tests with coverage
         run: yarn test --ci --coverage
       - uses: codecov/codecov-action@v5

.prettierrc.js

@@ -1,8 +1,11 @@
+"use strict";
+
 module.exports = {
 	printWidth: 80,
 	useTabs: true,
 	tabWidth: 2,
 	trailingComma: "none",
+	arrowParens: "always",
 	overrides: [
 		{
 			files: "*.json",

README.md

@@ -70,12 +70,12 @@ For sync hooks, `tap` is the only valid method to add a plugin. Async hooks also
 ```js
 myCar.hooks.calculateRoutes.tapPromise(
 	"GoogleMapsPlugin",
-	(source, target, routesList) => {
+	(source, target, routesList) => 
 		// return a promise
-		return google.maps.findRoute(source, target).then((route) => {
+		 google.maps.findRoute(source, target).then((route) => {
 			routesList.add(route);
-		});
-	}
+		})
+
 );
 myCar.hooks.calculateRoutes.tapAsync(
 	"BingMapsPlugin",
@@ -106,7 +106,7 @@ class Car {
 	/**
 	 * You won't get returned value from SyncHook or AsyncParallelHook,
 	 * to do that, use SyncWaterfallHook and AsyncSeriesWaterfallHook respectively
-	 **/
+	 */
 
 	setSpeed(newSpeed) {
 		// following call returns undefined even when you returned values
@@ -117,10 +117,10 @@ class Car {
 		const routesList = new List();
 		return this.hooks.calculateRoutes
 			.promise(source, target, routesList)
-			.then((res) => {
+			.then((res) => 
 				// res is undefined for AsyncParallelHook
-				return routesList.getRoutes();
-			});
+				 routesList.getRoutes()
+			);
 	}
 
 	useNavigationSystemAsync(source, target, callback) {

eslint.config.mjs

@@ -0,0 +1,20 @@
+import { defineConfig } from "eslint/config";
+import config from "eslint-config-webpack";
+
+export default defineConfig([
+	{
+		extends: [config],
+		rules: {
+			"no-new-func": "off",
+			"n/prefer-node-protocol": "off"
+		}
+	},
+	{
+		languageOptions: {
+			parserOptions: {
+				ecmaVersion: 2018
+			}
+		},
+		files: ["lib/__tests__/**/*.js"]
+	}
+]);

lib/AsyncParallelBailHook.js

@@ -49,7 +49,7 @@ class AsyncParallelBailHookCodeFactory extends HookCodeFactory {
 				code += "}\n";
 				return code;
 			},
-			onTap: (i, run, done, doneBreak) => {
+			onTap: (i, run, done, _doneBreak) => {
 				let code = "";
 				if (i > 0) {
 					code += `if(${i} >= _results.length) {\n`;
@@ -68,10 +68,10 @@ class AsyncParallelBailHookCodeFactory extends HookCodeFactory {
 
 const factory = new AsyncParallelBailHookCodeFactory();
 
-const COMPILE = function (options) {
+function COMPILE(options) {
 	factory.setup(this, options);
 	return factory.create(options);
-};
+}
 
 function AsyncParallelBailHook(args = [], name = undefined) {
 	const hook = new Hook(args, name);

lib/AsyncParallelHook.js

@@ -18,10 +18,10 @@ class AsyncParallelHookCodeFactory extends HookCodeFactory {
 
 const factory = new AsyncParallelHookCodeFactory();
 
-const COMPILE = function (options) {
+function COMPILE(options) {
 	factory.setup(this, options);
 	return factory.create(options);
-};
+}
 
 function AsyncParallelHook(args = [], name = undefined) {
 	const hook = new Hook(args, name);

lib/AsyncSeriesBailHook.js

@@ -23,10 +23,10 @@ class AsyncSeriesBailHookCodeFactory extends HookCodeFactory {
 
 const factory = new AsyncSeriesBailHookCodeFactory();
 
-const COMPILE = function (options) {
+function COMPILE(options) {
 	factory.setup(this, options);
 	return factory.create(options);
-};
+}
 
 function AsyncSeriesBailHook(args = [], name = undefined) {
 	const hook = new Hook(args, name);

lib/AsyncSeriesHook.js

@@ -18,10 +18,10 @@ class AsyncSeriesHookCodeFactory extends HookCodeFactory {
 
 const factory = new AsyncSeriesHookCodeFactory();
 
-const COMPILE = function (options) {
+function COMPILE(options) {
 	factory.setup(this, options);
 	return factory.create(options);
-};
+}
 
 function AsyncSeriesHook(args = [], name = undefined) {
 	const hook = new Hook(args, name);

lib/AsyncSeriesLoopHook.js

@@ -18,10 +18,10 @@ class AsyncSeriesLoopHookCodeFactory extends HookCodeFactory {
 
 const factory = new AsyncSeriesLoopHookCodeFactory();
 
-const COMPILE = function (options) {
+function COMPILE(options) {
 	factory.setup(this, options);
 	return factory.create(options);
-};
+}
 
 function AsyncSeriesLoopHook(args = [], name = undefined) {
 	const hook = new Hook(args, name);

lib/AsyncSeriesWaterfallHook.js

@@ -8,14 +8,14 @@ const Hook = require("./Hook");
 const HookCodeFactory = require("./HookCodeFactory");
 
 class AsyncSeriesWaterfallHookCodeFactory extends HookCodeFactory {
-	content({ onError, onResult, onDone }) {
+	content({ onError, onResult, _onDone }) {
 		return this.callTapsSeries({
 			onError: (i, err, next, doneBreak) => onError(err) + doneBreak(true),
 			onResult: (i, result, next) => {
 				let code = "";
 				code += `if(${result} !== undefined) {\n`;
 				code += `${this._args[0]} = ${result};\n`;
-				code += `}\n`;
+				code += "}\n";
 				code += next();
 				return code;
 			},
@@ -26,14 +26,15 @@ class AsyncSeriesWaterfallHookCodeFactory extends HookCodeFactory {
 
 const factory = new AsyncSeriesWaterfallHookCodeFactory();
 
-const COMPILE = function (options) {
+function COMPILE(options) {
 	factory.setup(this, options);
 	return factory.create(options);
-};
+}
 
 function AsyncSeriesWaterfallHook(args = [], name = undefined) {
-	if (args.length < 1)
+	if (args.length < 1) {
 		throw new Error("Waterfall hooks must have at least one argument");
+	}
 	const hook = new Hook(args, name);
 	hook.constructor = AsyncSeriesWaterfallHook;
 	hook.compile = COMPILE;

lib/Hook.js

@@ -11,18 +11,20 @@
 	"Hook.context is deprecated and will be removed"
 );
 
-const CALL_DELEGATE = function (...args) {
+function CALL_DELEGATE(...args) {
 	this.call = this._createCall("sync");
 	return this.call(...args);
-};
-const CALL_ASYNC_DELEGATE = function (...args) {
+}
+
+function CALL_ASYNC_DELEGATE(...args) {
 	this.callAsync = this._createCall("async");
 	return this.callAsync(...args);
-};
-const PROMISE_DELEGATE = function (...args) {
+}
+
+function PROMISE_DELEGATE(...args) {
 	this.promise = this._createCall("promise");
 	return this.promise(...args);
-};
+}
 
 class Hook {
 	constructor(args = [], name = undefined) {
@@ -38,13 +40,17 @@
 		this.promise = PROMISE_DELEGATE;
 		this._x = undefined;
 
+		// eslint-disable-next-line no-self-assign
 		this.compile = this.compile;
+		// eslint-disable-next-line no-self-assign
 		this.tap = this.tap;
+		// eslint-disable-next-line no-self-assign
 		this.tapAsync = this.tapAsync;
+		// eslint-disable-next-line no-self-assign
 		this.tapPromise = this.tapPromise;
 	}
 
-	compile(options) {
+	compile(_options) {
 		throw new Error("Abstract: should be overridden");
 	}
 
@@ -53,7 +59,7 @@
 			taps: this.taps,
 			interceptors: this.interceptors,
 			args: this._args,
-			type: type
+			type
 		});
 	}
 
@@ -150,12 +156,12 @@
 		let i = this.taps.length;
 		while (i > 0) {
 			i--;
-			const x = this.taps[i];
-			this.taps[i + 1] = x;
-			const xStage = x.stage || 0;
+			const tap = this.taps[i];
+			this.taps[i + 1] = tap;
+			const xStage = tap.stage || 0;
 			if (before) {
-				if (before.has(x.name)) {
-					before.delete(x.name);
+				if (before.has(tap.name)) {
+					before.delete(tap.name);
 					continue;
 				}
 				if (before.size > 0) {