Skip to content

fix: note the conditions under which the request couldn't be found #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2025

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Aug 17, 2025

i got really confused because there was an error saying something wasn't exported but it was - turns out it was just exported under the wrong conditions. this pr makes the error note the conditions it was expected to be exported under.

Copy link

linux-foundation-easycla bot commented Aug 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (52b61d0) to head (f1e1301).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   93.11%   93.13%   +0.01%     
==========================================
  Files          45       45              
  Lines        2151     2155       +4     
  Branches      651      654       +3     
==========================================
+ Hits         2003     2007       +4     
  Misses        119      119              
  Partials       29       29              
Flag Coverage Δ
integration 93.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait alexander-akait merged commit f1bc1c2 into webpack:main Aug 18, 2025
28 checks passed
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants