[Gecko Bug 2036298] Make nsIFrame::MoveCaretToEventPoint compare with the inclusive flattened tree ancestor element to consider if during a drag gesture#59610
Merged
moz-wptsync-bot merged 1 commit intomasterfrom May 1, 2026
Conversation
…ttened tree ancestor element to consider if during a drag gesture `EventStateManager::mGestureDownContent` needs to be a `Text` if the drag gestures started from the `Text` even though the event target should be its parent element. The reason is, various places maintain `Selection` with the `Text` node. On the other hand, `nsIFrame::MoveCaretToEventPoint` considers whether it's in a drag gesture with checking `mGestureDownContent` is different from its `mContent`. However, this is not enough if the text frame is reframed by a `mousedown` listener. In that case, we handle the `eMouseDown` event with the parent element's frame. Therefore, current code does not work with the editable `Text` in `<input>` and `<textarea>` (the drag starting to select from start of the `Text` and cannot collapse the non-collapsed selection). Therefore, we should check whether the frame content is different from the parent element of `mGestureDownContent` too. Differential Revision: https://phabricator.services.mozilla.com/D297855 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2036298 gecko-commit: b44c377383cd9f9df5b064a13b258cf071fe91ed gecko-reviewers: emilio, layout-reviewers
wpt-pr-bot
approved these changes
May 1, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventStateManager::mGestureDownContentneeds to be aTextif thedrag gestures started from the
Texteven though the event targetshould be its parent element. The reason is, various places maintain
Selectionwith theTextnode.On the other hand,
nsIFrame::MoveCaretToEventPointconsiders whetherit's in a drag gesture with checking
mGestureDownContentis differentfrom its
mContent. However, this is not enough if the text frame isreframed by a
mousedownlistener. In that case, we handle theeMouseDownevent with the parent element's frame. Therefore, currentcode does not work with the editable
Textin<input>and<textarea>(the drag starting to select from start of theTextandcannot collapse the non-collapsed selection). Therefore, we should
check whether the frame content is different from the parent element of
mGestureDownContenttoo.Differential Revision: https://phabricator.services.mozilla.com/D297855
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2036298
gecko-commit: b44c377383cd9f9df5b064a13b258cf071fe91ed
gecko-reviewers: emilio, layout-reviewers