Mark IndexedDB transactions inactive during key serialization#55660
Mark IndexedDB transactions inactive during key serialization#55660nolanlawson wants to merge 2 commits intomasterfrom
Conversation
odinho
left a comment
odinho
left a comment
There was a problem hiding this comment.
Looks good to me, I see the spec change has an okay already. This should probably go in at the same time the actual change comes in though.
You could probably also link this to the spec text before doing the merge once the spec text is up? Or update it. If w3ctests even use links anymore.
|
Thanks for the review! I just updated the tests based on some feedback in the spec PR: w3c/IndexedDB#479 (comment) . I'll wait for an OK on both PRs before merging. |
asutherland
left a comment
asutherland
left a comment
There was a problem hiding this comment.
Great coverage from a very clean and nicely factored test, thank you!
| // META: timeout=long | ||
| 'use strict'; | ||
|
|
||
| const setupKetSerializationTest = async (testCase) => { |
There was a problem hiding this comment.
typo nit: I think Ket is meant to be Key here (and its many uses)? A comment is probably appropriate if if it's not a typo.
4 participants
Helps close w3c/IndexedDB#476.
This test is largely based on
structured-clone-transaction-state.any.jsand is designed to match Firefox's implementation. WebKit and Chromium currently fail this test.