Move some tests from toascii.json to urltestdata.json#38813
Conversation
These were introduced in e9a1061. However, these are not tests of the Unicode ToASCII algorithm. They are tests of the extra step introduced in whatwg/url@cceb435 to the URL Standard. Keep toascii.json focused on testing the ToASCII algorithm, so that software which implements it can use that file.
|
I agree with moving these tests from |
|
Now an idea came to mind: I think even better to move these tests to a new file, say /cc @annevk |
|
I think that might be reasonable, but I'm quickly reaching the limit of the extra effort I'm willing to put in here myself. I'm just trying to correct a bug so that my ToASCII library can be tested properly... |
| }, | ||
| { | ||
| "comment": "Empty host after domain to ASCII", | ||
| "input": "https://\u00AD/", |
There was a problem hiding this comment.
Add required base: parameter, the same for remaining two tests.
rmisev
left a comment
rmisev
left a comment
There was a problem hiding this comment.
Overall OK, you just skipped the required base: parameter in the last three tests in the urltestdata.json file.
5 participants
These were introduced in e9a1061. However, these are not tests of the Unicode ToASCII algorithm. They are tests of the extra step introduced in whatwg/url@cceb435 to the URL Standard.
Keep toascii.json focused on testing the ToASCII algorithm, so that software which implements it can use that file.
/cc @rmisev