refactor(module-concatenation): reduce try_to_add allocations#13741
Draft
LingyuCoder wants to merge 3 commits intomainfrom
Draft
refactor(module-concatenation): reduce try_to_add allocations#13741LingyuCoder wants to merge 3 commits intomainfrom
LingyuCoder wants to merge 3 commits intomainfrom
Conversation
github-actions
Bot
added
the
team
Contributor
|
📝 Benchmark detail: Open No benchmark data for commit ed6830a, trying parent...
|
LingyuCoder
changed the title
Contributor
📦 Binary Size-limit
🎉 Size decreased by 4.00KB from 62.72MB to 62.72MB (⬇️0.01%) |
Merging this PR will degrade performance by 3.02%
Performance Changes
Comparing 
Footnotes |
Contributor
|
📝 Benchmark detail: Open No benchmark data for commit ed6830a, trying parent...
Threshold exceeded: ["arco-pro_production-mode_persistent-hot + exec"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleConcatenationPlugin::try_to_addhot-path allocations by caching import lists asArc<[ModuleIdentifier]>filter(...).collect::<Vec<_>>()checks with single-pass scans in module concatenationWhy
samplyoncases/10000showedtry_to_addconsuming a large share of module concatenation time, with noticeableIndexSetclone and temporaryVecallocation overheadtry_to_addshare within module concatenation from 32.74% to 27.24%Validation
cargo fmt --all --checkcargo lintcargo test -p rspack_plugin_javascript module_concatenation_plugin -- --nocapture