perf(real-content-hash): skip redundant work in hash pass#13647
Draft
LingyuCoder wants to merge 1 commit intomainfrom
Draft
perf(real-content-hash): skip redundant work in hash pass#13647LingyuCoder wants to merge 1 commit intomainfrom
LingyuCoder wants to merge 1 commit intomainfrom
Conversation
github-actions
Bot
added
the
team
Contributor
|
📝 Benchmark detail: Open
|
github-actions
Bot
added
the
release: bug fix
LingyuCoder
changed the title
github-actions
Bot
added
release: performance
Merging this PR will degrade performance by 36.71%🎉 Hooray!
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | js@Traverse module graph by dependencies |
530.2 µs | 837.7 µs | -36.71% |
Comparing codex/real-content-hash-fast-paths (05fb33a) with main (84288f4)
Footnotes
-
28 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Contributor
Rsdoctor Bundle Diff Analysis
Found 6 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
❌ Size increased by 416bytes from 49.35MB to 49.35MB (⬆️0.00%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch_sources/asset_contentswhen noupdate_hashhook is registeredRelated links
Why
RealContentHashPluginwas doing extra allocation and bookkeeping work even when assets had no relevant hash matches, when no hook consumed the rebuilt sources, or when the final asset update was effectively a no-op. This change keeps the existing behavior but removes those redundant paths.Validation
cargo test -p rspack_plugin_real_content_hashcargo clippy -p rspack_plugin_real_content_hash --all-targets -- -D warningscargo fmt --all --checkpnpm run build:binding:devpnpm -C tests/rspack-test exec rstest run --include Hash.test.js -t "hashCases-hashCases/real-content-hash" --project base --bail 1pnpm -C tests/rspack-test exec rstest run --include Config.part3.test.js -t "configCases-configCases/sri/runtime-requirement" --project base --bail 1Checklist