[Bug]: `resolve.dedupe` should support exports fields

[SoonIter]

Version

@rsbuild/core 1.3.21

Details

"The alias expanded to an absolute path does not respect exports field."

1. config like this

// rsbuild.config.ts
resolve: {
   dedupe: ['@tt/web']
}

Add the following two aliases to rspack:

// rspack.config.ts(Rsbuild actually generated)
resolve: {
   alias: {
     "@tt/web$": '/usr/demos/rsbuild/node_modules/.pnpm/@tt+web@1.0.19/@tt/web',
     "@tt/web/*": '/usr/demos/rsbuild/node_modules/.pnpm/@tt+web@1.0.19/node_modules/@tt/web' 
   }
}

If the user writes as below

import foo from "@tt/web/canary" 

it is actually equal to

import foo from "/usr/demos/rsbuild/node_modules/.pnpm/@tt+web@1.0.19/node_modules/@tt/web/canary"

At this moment, if the exports of @tt/web are written like this:

// @tt/web/package.json
exports: {
   "./canary": "./dist/canary.js"
}

Error: resolve not found

Reproduce link

none

Reproduce Steps

none

[SoonIter]

My idea is to modify it to this API, which can solve this problem and make it more user-friendly.

resolve: {
   alias: {
     "@tt/web/(.*)": {
           base: "/usr/demos/rsbuild/node_modules/.pnpm/@tt+web@1.0.19/node_modules/@tt/web",
           request: "@tt/web/$1"
     }
   }
}

[chenjiahan]

Related: https://github.com/jkrems/proposal-pkg-exports/#:~:text=The%20exports%20target%20must%20be%20a%20string%20and%20start%20with%20%22./%22%20(URLs%20and%20absolute%20paths%20are%20not%20currently%20supported%20but%20may%20be%20supported%20in%20future).

[nanianlisao]

It seems that there is no perfect solution to this problem, so is there an option to provide a more open configuration. Let users customize subpath configuration.

For example, ‘@tt/web/xxx’, through require.resolve, you actually get the real address and support the exports field. So it may be necessary to modify the internal dedupe solution to get alias path. Of course, this seems to have some problems.

@chenjiahan @SoonIter cc

[colinaaa]

Any progress on this?

If the resolver cannot resolve wildcard correctly for now, can we iterate over exports in Rsbuild and set alias using manually resolve (with correct conditionName)?

[chenjiahan]

No progress yet.. @stormslowly cc

[zardoy]

I’ve run into an issue when working with linked packages (for example, linking another local package for development) using yarn link / pnpm link. The setup looks like this:

my-project/node_modules/react   <- this version is used for direct imports in my project
my-project/package.json:
  "dep-a": "link:../dep-a"

dep-a/node_modules/react        <- but some code inside dep-a ends up using this one

I assumed I could fix this with just resolve.dedupe = ["*"], but because many packages now rely on the exports field, this seems to be a major limitation for such scenarious.

I know about using the file: protocol, but with Yarn you lose file change updates (you need a full reinstall on every change), and even with pnpm which is better there are still annoying limitations.

Are there any recommended ways to handle local package development? Or maybe a some other hack that can be used (though tbh I think rsbuild should handle such scenarious with out-of-the box solution or proposal to fix it).

[zardoy]

Ok, sorry, I have found that in case if code is imported from different node_modules, it is really easy to solve by simply forcing only one lookup location with

rspack(config, { addRules}) {
      config.resolve.modules = [path.join(__dirname, 'node_modules')]
}

and I just do this in package.json

my-project/package.json:
  "dep-a": "link:../dep-a",
  "dep-a-2": "file:../dep-a" // <- file: protocol to trick pnpm into installing its dependencies into our node_modules directory

or just simply portal: protocol in latest Yarn

hope it would help anyone else running into the same thing

[SoonIter]

Some relevant information:

• https://esbuild.github.io/plugins/#on-resolve-arguments

The resolve hook in esbuild can change resolveDir (like base)

[sgarfinkel]

Just want to plug this as a very nice to have. https://github.com/rstackjs/rsbuild-plugin-source-build does not work with dedupe because this is not yet implemented.