This repository was archived by the owner on Dec 7, 2023. It is now read-only.
ignited: allow running help, completion, version subcommands without root permission #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stage Also fixed incorrect populated provider (ignite -> ignited).
folliehiyuki
requested review from
chanwit,
darkowlzz and
stealthybox
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a copy and paste of #676 but for
ignitedcommand.I also did some minor extra things:
GenericCheckErrcalls from to PersistentPreRun stage of cobra. A couple of them are already there to begin with (this specially helpsignitedcommand as Preload checks forMANIFEST_DIRand fails).isNonRootCommand()function (we already handle each subcommands).ignitedprovider (it wasignite).