Print warnings to STDERR to avoid polluting STDOUT#96
Print warnings to STDERR to avoid polluting STDOUT#96dmatysiak wants to merge 60 commits intoweavejester:masterfrom
Conversation
|
@weavejester I'm running into an issue now where a Can this PR be merged into a new release? I'd like to uptake it so that I can introduce Environ into this app, but it's a hard sell to the team if I can't get it working without kludges. |
|
This PR fell between the cracks for me. I'd be fine with merging it, once the small typo in the commit message is fixed: |
dmatysiak
changed the title
|
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
|
Fixes weavejester#7 and introduces small backward incompatibility. Shouldn't affect the vast majority of users.
Should prevent issues with :reload-all and changing .lein-env files. Partially fixes weavejester#5.
This replicates the equivalent functionality in Leiningen, where keywords like :project/version are replaced with the value of the key :version from the project map.
Signed-off-by: SergeyKozachenko <sergiy.kozachenko@gmail.com>
|
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
|
|
Hi @weavejester . Any update on this PR? I was also bitten by environ writing to stdout 😅 |
As I said in my previous comment, I'm happy to merge once the typo in the commit message is corrected. This PR also now has 60 commits for some reason, when it should have 1. |
|
Thanks for the super quick response @weavejester ! Yeah, I noticed all the commits; I don't know what happened. I'm not the author of the PR, so maybe we can ping @dmatysiak ? |
|
See #97. Didn't want to fiddle with the mess I accidentally made with the commit history in this branch. |
Nice! :) Thanks 🙏 |
17 participants
Printing warnings to STDOUT pollutes the output of any program that uses STDOUT. This patch makes sure warnings are directed to STDERR.