Read boot-env using io/resource and io/reader#81
Open
larkery wants to merge 1 commit intoweavejester:masterfrom
Open
Read boot-env using io/resource and io/reader#81larkery wants to merge 1 commit intoweavejester:masterfrom
larkery wants to merge 1 commit intoweavejester:masterfrom
Conversation
Owner
|
Thanks for the patch. Can you wrap the commit message at 72 characters and add a reference to the issue being solved, e.g. something like: |
Previously, classpath resources were assumed to be files and passed to io/file. This failed when the resource was within a jar. The fix is to use io/reader instead, which works on resources within or without jars. Fixes: weavejester#80
60c58c5 to
8167510
Compare
Author
|
I've twiddled the commit a bit to reformat the message and put in a test that .boot-env is read off the classpath as a resource. |
Owner
|
Thanks! However I think the commit message should make it clear that including We don't need to explain exactly how it was fixed, since I think that's self-explanatory for the diff. Both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously used io/file with io/resource, which is not safe when the resource is not a file.
Something like this should work?