Remove unused view partials and document cleanup

[jjmata]

Summary

• remove unused view partials across accounts, credit cards, transfers, and shared layout helpers
• drop unused shared helpers such as the version badge, logo, and text tooltip
• add documentation noting the dead view cleanup

Dead view cleanup

This change removes a set of unused view partials that were no longer rendered anywhere in the application:

• app/views/accounts/show/_activity.html.erb
• app/views/credit_cards/_overview.html.erb
• app/views/transfers/_account_links.html.erb
• app/views/layouts/shared/_page_header.html.erb
• app/views/shared/_app_version.html.erb
• app/views/shared/_logo.html.erb
• app/views/shared/_text_tooltip.erb

Keeping only referenced templates helps simplify the view layer and avoid confusion during future refactors.

Testing

• not run (not requested)

---

Codex Task

Summary by CodeRabbit

• Refactor
  • Removed unused UI components: account activity display panel, credit card summary overview cards, page header sections, application version badge, navigation logo, tooltip functionality, and transfer account linking interface
  • Optimized code by eliminating unused variable initialization in transfer matching logic

[coderabbitai]

Walkthrough

This pull request removes eight view partials and simplifies a single model method. The deletions include activity and credit card overview panels, layout components (header, logo, version badge, tooltip), and transfer-related UI. One unused variable initialization is removed from the auto-transfer matching logic without affecting functional behavior.

Changes

Cohort / File(s)	Summary
Shared and Layout Partials app/views/layouts/shared/_page_header.html.erb, app/views/shared/_app_version.html.erb, app/views/shared/_logo.html.erb, app/views/shared/_text_tooltip.erb	Removed four shared UI components: page header (title/subtitle rendering), version badge (top-right fixed badge), logo link, and tooltip container.
Domain-Specific View Partials app/views/accounts/show/_activity.html.erb, app/views/credit_cards/_overview.html.erb, app/views/transfers/_account_links.html.erb	Deleted account activity panel (with entry list, search, pagination, bulk-select UI), credit card overview grid (amount owed, available credit, minimum payment, APR, expiration, annual fee), and transfer account link rendering.
Model Logic Simplification app/models/family/auto_transfer_matchable.rb	Removed initialization of unused candidates empty array variable in auto_match_transfers method; functional behavior unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify no remaining code references these deleted view partials (particularly _activity.html.erb which involved complex state management with bulk-select and pagination)
• Confirm the removal of the candidates variable initialization in auto_transfer_matchable.rb doesn't impact any edge cases or error handling
• Check that credit card overview display logic is handled elsewhere if this was active functionality

Poem

🐰 The views fade away like morning dew,
Logo, headers, tooltips bid adieu,
Code grows cleaner with each deletion,
An elegant spring code reclamation! 🌱

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately reflects the main change: removal of unused view partials and document cleanup, which aligns with the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/identify-dead-code-in-the-repo

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92b35b2 and 32fd4ea.

📒 Files selected for processing (1)

• app/models/family/auto_transfer_matchable.rb (0 hunks)

💤 Files with no reviewable changes (1)

• app/models/family/auto_transfer_matchable.rb

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: ci / test
• GitHub Check: Cursor Bugbot

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jjmata]

(from Codex)

Confirmed dead code paths:

• app/views/accounts/show/_activity.html.erb – Legacy account activity tab markup that builds its own search form, toolbar, and entry list, but the show page now delegates to UI::AccountPage, which only calls the with_activity_feed slot and never renders this partial anymore.
• app/views/credit_cards/_overview.html.erb – Static summary card grid for credit-card accounts (balance, available credit, APR, etc.) that is never referenced by credit_cards#new, #edit, or any other template, so none of the controller actions render it.
• app/views/transfers/_account_links.html.erb – Helper partial intended to display two linked account names for a transfer (including error fallbacks and arrow icons). No view renders "transfers/account_links" or even contains the string account_links, so the helper is effectively dead.
• app/views/layouts/shared/_page_header.html.erb – A layout-level helper for rendering a title/subtitle block. The application layout now exposes a content_for :page_header slot instead, and no template renders "layouts/shared/page_header", leaving this partial unused.
• app/views/shared/_app_version.html.erb – Fixed-position badge that prints Sure.version in the UI. No template renders "shared/app_version", so the version badge never appears anywhere.
• app/views/shared/_logo.html.erb – Standalone partial that links the logomark back to root_path. Call sites link directly with image_tag instead (searching for shared/logo returns no results), so this helper is dead.
• app/views/shared/_text_tooltip.erb – Tooltip wrapper intended to be rendered via render "shared/text_tooltip", but no ERB template references that path anymore, so the markup is never emitted.

These are the only additional “dead” templates I could confirm via repository-wide searches beyond the already-identified app/views/accounts/show/_activity.html.erb.