Mini challenge 5 #72
Open
Mini challenge 5 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- YouTubeProvider to handle context. - Accepting search parameter to useVideos.
- VideoDetail displaying title and description. - useRelatedVideos hook. - layout improved. - RelatedVideos in progres...
- handling error from YouTube API
- useVideo hook created. - removing state. - RelatedVideos isolated.
- Using react-query for better localStoarge handling.
- Favorites List and Detail working. - Navigation links added to header.
PacoMojica
reviewed
Apr 7, 2021
PacoMojica
left a comment
PacoMojica
left a comment
There was a problem hiding this comment.
Hello Alfredo!, your project looks good, the only thing missing are the tests, I don't think that is going to be a problem, I'll talk to the academy team and see what they say. I liked reviewing you code, thanks for attending the bootcamp! 🙂
Author
|
Thanks to you Paco!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my mini-challenge-5 solution.
Acceptance Criteria:
✔ All the sections have their own route. @done
✔ Navigation across the sections is implemented correctly. @done
✔ The Global State is persistent across all the sections. @done
✔ The "Mocked Authentication" mechanism works correctly. @done
✔ The "session data" is stored in the Global Context correctly. @done
✔ Videos can be added to the Favorites list. @done
✔ Videos can be removed from the Favorites list. @done
✔ Navigation to Favorite Videos View using a private route is implemented correctly (only authenticated users should access this section). @done
✔ Navigation to the Favorite Video Details View using a private route is implemented correctly (only authenticated users should access this section). @done
✔ Information for the selected favorite video is displayed correctly @done
✔ The list of other favorite videos in the Favorite Video Details View is displayed. @done
☐ Testing coverage is above 70%. (Please include a screenshot of the code coverage report in your PR description).
Bonus Points:
☐ The Add/remove from favorites button should appear when the user passes the mouse over the video card in the list.
☐ Integrate with a real authentication provider (such as Auth0, OAuth or Firebase).
✔ A 404 section is shown when a route is not found. @done
☐ The Login View is implemented as a modal using React Portals.