Mini challenge 2 #33
Open
Mini challenge 2 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 19, 2021 22:39
- Button - emoji :D - add GlobalStyle to change from a button action - add mock data
- delete missing css file - fix index exporting name
This reverts commit 443412c.
- add placeholder to search button - delete console.table - add key for card list
|
|
||
| const intervalId = setInterval(rotateBackground, 3000); | ||
| body.addEventListener('click', rotateBackground); | ||
| const GlobalStyles = createGlobalStyle`body{ |
|
|
||
| function Card({ title, description, image, width, height }) { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
This div is unnecessary. It'd be good to take it out to reduce items in the tree.
| return ( | ||
| <div> | ||
| <Container> | ||
| <center> |
There was a problem hiding this comment.
This is deprecated: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/center
I'd recommend to just style the container to have centered text instead of this approach.
guillermo-rebolledo
left a comment
guillermo-rebolledo
left a comment
There was a problem hiding this comment.
Looking good! I left some comments in the code.
Also, I think the styles are still missing some adjustments:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes performed:
Questions on challenge 2:
using
create-react-appincludesjestto testingthe components that programmer create that includes business logic
it is better to using TDD at the beginning of development or along with it, at the end could be applied but maybe you will find corner cases and you will need spend extra time covering