fix(transport): route code-less error frames as warnings - #767
Open
tradatious wants to merge 1 commit into
Open
Conversation
tradatious
force-pushed
the
codeless-notice-warning
branch
from
August 29, 2026 00:22
3468d48 to
c19eaa1
Compare
A protobuf error frame whose error_code field is absent decodes to code 0, which is outside WARNING_CODE_RANGE, so classify_error treated it as a request-less hard error and failed every in-flight one-shot shared request. IB Gateway sends such code-less frames for informational notices, e.g. "Warning: Approaching max rate of 50 messages per second (42)". Code-0 frames now route as warnings: request-less ones reach the notice stream only, and ones with a request id are delivered as a notice instead of terminating the subscription. An error frame that fails proto decode falls back to the same code-0 path; determine_routing now logs a warning naming the byte length for that case.
tradatious
force-pushed
the
codeless-notice-warning
branch
from
August 29, 2026 00:46
c19eaa1 to
547c41d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A protobuf error frame whose error_code field is absent decodes to code 0, which is outside WARNING_CODE_RANGE, so classify_error treated it as a request-less hard error and failed every in-flight one-shot shared request. IB Gateway sends such code-less frames for informational notices, e.g. "Warning: Approaching max rate of 50 messages per second (42)".
Code-0 frames now route as warnings: request-less ones reach the notice stream only, and ones with a request id are delivered as a notice instead of terminating the subscription. An error frame that fails proto decode falls back to the same code-0 path; determine_routing now logs a warning naming the byte length for that case.
Fix for #766