Skip to content

Guard pointer asserts on null-y-type arguments #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard pointer asserts on null-y-type arguments #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/scalapackpp/geadd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ detail::enable_if_scalapack_supported_t<T>
detail::type_identity_t<T> BETA,
T* C, int64_t IC, int64_t JC, const scalapack_desc& DESCC ) {

assert( A != C );
if(A or C) assert( A != C );

auto TRANS = char( trans );

Expand Down
4 changes: 2 additions & 2 deletions include/scalapackpp/pblas/gemm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ detail::enable_if_scalapack_supported_t<T>
detail::type_identity_t<T> BETA,
T* C, int64_t IC, int64_t JC, const scalapack_desc& DESCC ) {

assert( A != C );
assert( B != C );
if(A or C) assert(A != C);
if(B or C) assert(B != C);

auto TRANSA = char( transa );
auto TRANSB = char( transb );
Expand Down
4 changes: 2 additions & 2 deletions include/scalapackpp/pblas/hemm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ detail::enable_if_t<
BETAT BETA,
T* C, int64_t IC, int64_t JC, const scalapack_desc& DESCC ) {

assert( A != C );
assert( B != C );
if(A or C) assert( A != C );
if(B or C) assert( B != C );

auto SIDE = char( side );
auto UPLO = char( uplo );
Expand Down
4 changes: 2 additions & 2 deletions include/scalapackpp/pblas/symm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ detail::enable_if_t<
BETAT BETA,
T* C, int64_t IC, int64_t JC, const scalapack_desc& DESCC ) {

assert( A != C );
assert( B != C );
if(A or C) assert( A != C );
if(B or C) assert( B != C );

auto SIDE = char( side );
auto UPLO = char( uplo );
Expand Down
2 changes: 1 addition & 1 deletion include/scalapackpp/tradd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ detail::enable_if_scalapack_supported_t<T>
detail::type_identity_t<T> BETA,
T* C, int64_t IC, int64_t JC, const scalapack_desc& DESCC ) {

assert( A != C );
if(A or C) assert( A != C );

auto TRANS = char( trans );
auto UPLO = char( uplo );
Expand Down