Skip to content

Conversation

@wleslie
Copy link
Contributor

@wleslie wleslie commented Sep 15, 2021

Creates parent dirs of output directory if necessary. This makes the behavior consistent with the
rest of Webpack (for example, the output.path config setting creates parent dirs as needed).

@wleslie
Copy link
Contributor Author

wleslie commented Sep 15, 2021

Note that wasm-pack itself creates its output dir recursively, but wasm-pack-plugin also attempts to create this directory first, non-recursively, so it will fail if the parent dir does not exist. This change fixes that.

(Aside: due to #74, wasm-pack and wasm-pack-plugin have different ideas about what the output dir is relative to, so two directories end up getting created.)

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase? but change lgtm

Creates parent dirs of output directory if necessary. This makes the behavior consistent with the
rest of Webpack (for example, the `output.path` config setting creates parent dirs as needed).
@xtuc xtuc merged commit 89f36b6 into wasm-tool:master Oct 3, 2021
@xtuc
Copy link
Member

xtuc commented Oct 3, 2021

Published in @wasm-tool/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants