fix(core): alert user to missing global services#890
Conversation
|
Given that PMA can be disabled using It would rather be better to refactor the peered service(s) to be only those that can't be opted out of (e.g. traefik, mailpit), and a separate process for "optional" services (e.g. portainer, dnsmasq, PMA) that first checks if they're enabled, and if so would add them to peered services list. |
|
I wasn't aware of the feature flag, thanks for bringing that up. I agree the peered services implementation could do with some improvements, to better support optionally attached services. I'll open a separate issue/PR to address that, and keep conversations focused. Although I still think the alert is a valuable addition, dependent on resolving the optional services issue. As it is essentially saying the global services state is not as expected. EG:
|
Check List
Describe the bug
If a core service is missing, you get a generic no such container error message, and the application will still attempt to run.
To Reproduce
Steps to reproduce the behavior:
0.15.0warden svc upwarden env upExpected behavior
Fatal error to occur to indicate to the user, that the core is in a unhealthy/outdated state.
Screenshots

Before:
After:
