Add environment version support.#773
Open
hardyjohnson wants to merge 1 commit into
Open
Conversation
bap14
reviewed
Aug 10, 2024
| WARDEN_USAGE=$(cat <<EOF | ||
| \033[33mUsage:\033[0m | ||
| env-init <project_name> <environment_type> | ||
| env-init <project_name> <environment_type> <environment_version> |
Member
There was a problem hiding this comment.
Since <environment_version> is optional, it should be surrounded by square brackets: [<environment_version>]; otherwise, it appears to be a required argument.
Member
There was a problem hiding this comment.
There are a lot of files that may be exact copies. I feel it would be better if we adjusted the environment files to use a fallback mechanism. If a file doesn't exist in the specific version, it loads from default. This would simplify the environment releases to potentially just init.env files.
Member
|
@hardyjohnson You'll want to resolve the conflicts that exist as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds versioning of the prebuilt environment configurations as per discussion here: https://github.com/orgs/wardenenv/discussions/772#discussion-6782904
Environment versioning
In order to more accurately and effectively support the modeling of an application's services and their configurations,
an "environment" within Warden, we should add a versioning methodology to each supported environment.
Adding an environment versioning constraint will allow us to support accurate representation of the necessary services and configuration necessary to run a particular application and support it over time.
Current issues with the pre-built environments today:
Proposed solution:
Usage
Environment initialization:
warden env-init newapp magento2 2.4.7This PR includes environments Magento2 (2.45, 2.4.6, 2.4.7) as per https://experienceleague.adobe.com/en/docs/commerce-operations/release/versions on premise commerce versions table.
cc/ @bap14 @navarr