Skip to content

chore(weave): mount internal JWT on weave scoring/eval workers - #653

Open
jwlee64 wants to merge 2 commits into
mainfrom
chore/weave-internal-jwt-scoring-eval-workers
Open

chore(weave): mount internal JWT on weave scoring/eval workers#653
jwlee64 wants to merge 2 commits into
mainfrom
chore/weave-internal-jwt-scoring-eval-workers

Conversation

@jwlee64

@jwlee64 jwlee64 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Related: wandb/core#47739 (prod fix), #598 (original weave-worker mount)

Note: weave-trace-worker (scoring_worker) already had the mount from #598; there is no separate call-scoring deployment in this chart.

Test plan

  • ./snapshots.sh build operator-wandb && ./snapshots.sh update operator-wandb
  • ./snapshots.sh run operator-wandb

Made with Cursor

Summary by CodeRabbit

  • New Features

    • Enabled secure service-account authentication for model evaluation and agent-scoring workers.
    • Added internal access permissions for these worker services.
  • Chores

    • Updated the Helm chart version to 0.43.10.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Helm chart now configures internal JWT authentication for the evaluate-model and agent-scoring workers. It adds projected service-account token mounts, allowlists both worker identities, and increments the chart version.

Changes

Worker internal JWT access

Layer / File(s) Summary
Worker JWT mounts and allowlist
charts/operator-wandb/values.yaml, charts/operator-wandb/Chart.yaml
The chart allowlists both worker service accounts and mounts projected tokens with the internal-service audience and 600-second expiration. The chart version changes to 0.43.10.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: zacharyblasczyk, adityachoudhari26

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The chart adds projected JWT mounts and allowlist entries for both target workers, matching the stated internal authentication requirements.
Out of Scope Changes check ✅ Passed The changes are limited to the related Helm chart version bump and internal JWT configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes mounting the internal JWT on the Weave scoring and evaluation workers.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/weave-internal-jwt-scoring-eval-workers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jtschoonhoven

Copy link
Copy Markdown
Contributor

Why is this needed? Was something broken?

@jwlee64

jwlee64 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

protocol: TCP
volumeMounts:
- name: weave-trace-internal-jwt
mountPath: /tmp/weave-trace/internal-jwt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mountPath: /tmp/weave-trace/internal-jwt
mountPath: /var/run/secrets/weave-trace

I think this would be more correct, than mounting under /tmp

the token is then at: /var/run/secrets/weave-trace/token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants