chore(weave): mount internal JWT on weave scoring/eval workers - #653
chore(weave): mount internal JWT on weave scoring/eval workers#653jwlee64 wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughThe Helm chart now configures internal JWT authentication for the evaluate-model and agent-scoring workers. It adds projected service-account token mounts, allowlists both worker identities, and increments the chart version. ChangesWorker internal JWT access
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Why is this needed? Was something broken? |
| protocol: TCP | ||
| volumeMounts: | ||
| - name: weave-trace-internal-jwt | ||
| mountPath: /tmp/weave-trace/internal-jwt |
There was a problem hiding this comment.
| mountPath: /tmp/weave-trace/internal-jwt | |
| mountPath: /var/run/secrets/weave-trace |
I think this would be more correct, than mounting under /tmp
the token is then at: /var/run/secrets/weave-trace/token
Summary
weave-evaluate-model-workerandweave-trace-agent-scoring-worker, matching the pattern from chore(weave): mount internal JWT + allowlist worker SA on gorilla #598Related: wandb/core#47739 (prod fix), #598 (original weave-worker mount)
Note:
weave-trace-worker(scoring_worker) already had the mount from #598; there is no separate call-scoring deployment in this chart.Test plan
./snapshots.sh build operator-wandb && ./snapshots.sh update operator-wandb./snapshots.sh run operator-wandbMade with Cursor
Summary by CodeRabbit
New Features
Chores