feat(weave): wire weave-trace file-payload storage to the wandb bucket - #610
Draft
gtarpenning wants to merge 1 commit into
Draft
gtarpenning wants to merge 1 commit into
gtarpenning wants to merge 1 commit into
Conversation
The weave-trace server + workers had no file-storage config in operator-wandb, so attachment/file payloads couldn't be written. Add wandb.weave.fileStorageEnvs deriving WF_FILE_STORAGE_URI + per-provider creds from the existing wandb bucket (S3/Azure reuse the bucket secret; GCS uses workload identity), wired into the trace server and both workers, plus project ramp/allow-list gating. Opt-in (global.weave.fileStorage.enabled=false) since the server has no S3 endpoint override and can't target MinIO/S3-compatible stores. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm-charts counterpart to wandb/core#45284 (which granted the SaaS weave-trace SA GCS perms). That PR was small because the core chart already wires the storage env; operator-wandb wired none, so weave-trace + workers cannot write file payloads at all.
Summary
wandb.weave.fileStorageEnvsderivingWF_FILE_STORAGE_URI+ per-provider creds from the existing wandb bucket (global.bucket/defaultBucket). S3/Azure reuse the bucket secret; GCS uses workload identity (ADC), since its client needs a service account, not gorilla’s S3-interop HMAC key.WF_FILE_STORAGE_PROJECT_ALLOW_LIST/_RAMP_PCTgating.global.weave.fileStorage.enabled=false): the server talks to real AWS S3 / GCS / Azure only (no endpoint override), so MinIO/S3-compatible stores stay off.Testing
helm template across s3/gcs/az + disabled; existing weave-trace-with-worker test config renders unchanged.