This repository was archived by the owner on Apr 7, 2026. It is now read-only.
Feature: user-selectable theme#460
Merged
Merged
Conversation
Changed sorting state from @State to @AppStorage in EntriesView to ensure user preferences are saved to UserDefaults. Also made sorting criteria mutually exclusive for a better UX.
Moved language files and other resources into a sub-folder to clean up the structure a little.
bourvill
reviewed
Feb 24, 2026
| @AppStorage("badge") var badge: Bool = true | ||
| @AppStorage("defaultMode") var defaultMode: String = RetrieveMode.allArticles.rawValue | ||
| @AppStorage("itemPerPageDuringSync") var itemPerPageDuringSync: Int = 50 | ||
| @ObservedObject var appSetting: AppSetting = Container.shared.appSetting() |
Contributor
There was a problem hiding this comment.
Hello, use EnvironmentObject instead ObservedObject
Contributor
Author
There was a problem hiding this comment.
Thanks - I'm new to iOS dev so am still getting the hang of things. I've pushed an update with that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability for users to select the theme (light/dark/auto).
I added translations for each supported language - they are AI-generated so I apologise if they're incorrect (I have no way of confirming).
I also moved the language files and other resources into App/Resources to tidy up the directory structure a little.