Fix invalid image paths producing invalid epubs #6#7
Draft
deviantintegral wants to merge 2 commits into
Draft
Conversation
deviantintegral
commented
May 24, 2025
Comment on lines
+690
to
+691
| assert(strlen($lastComponent) <= 255, "File name greater than 255 characters: " . $lastComponent); | ||
| assert(strlen($filePath) <= 65535, "File path greater than 65535 characters: " . $filePath); |
Author
There was a problem hiding this comment.
Even if someone enables assertions in "production" this seems safe to me because the spec says this specifically.
deviantintegral
commented
May 24, 2025
Comment on lines
+696
to
+697
| assert(preg_match('/^[a-zA-Z0-9\-\_\.\/]+$/', $filePath), | ||
| "File path '$filePath' contains invalid characters. Only ASCII letters, numbers, hyphens, underscores, dots and forward slashes are allowed."); |
Author
There was a problem hiding this comment.
This, I am less sure about. A filename could contain unicode characters and work fine on a given device or app. But, the spec specifically says that the list of invalid characters is not exhaustive, and that implementations should be conservative. Then again, if this breaks for someone, I also think it would be reasonable to say "just turn off assertions".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6.
I've marked this as draft because I'd like to get test coverage in place, but that's also a bigger scope.