config: add shared openw3d.conf path handling and --ini override by caseychaos1212 · Pull Request #104 · w3dhub/OpenW3D

caseychaos1212 · 2026-03-20T05:19:28Z

This follows up the INI-backed config work by moving openw3d.conf path
resolution into shared wwlib code and by teaching the game and legacy
wwconfig entry points to honor an explicit --ini PATH override.

What this changes:

adds a shared config-path resolver in wwlib
supports --ini PATH in renegade and wwconfig
resolves config in this order:
1. explicit --ini PATH
2. OPENW3D_CONFIG_INI / RENEGADE_CONFIG_INI
3. portable openw3d.conf next to the executable if it already exists
4. standard per-user config path
resolves the --ini path before any --gamedir handling can change the working directory
creates parent directories before saving to per-user config locations
forwards the explicit config path when renegade launches wwconfig.exe
treats POSIX-style absolute paths as absolute in the shared file factory

madebr · 2026-03-20T05:45:05Z

+#ifdef _WIN32
+		char path[MAX_PATH] = { 0 };
+		DWORD length = GetCurrentDirectoryA(ARRAY_SIZE(path), path);
+		if (length > 0 && length < ARRAY_SIZE(path)) {
+			return std::filesystem::path(path);
+		}
+#else
+		char path[4096] = { 0 };
+		if (getcwd(path, sizeof(path)) != NULL) {
+			return std::filesystem::path(path);
+		}


Perhaps use the OPENW3D_WIN32 and OPENW3D_SDL3 macros?
There is std::filesystem::current_path to get the working directory so the unix getcwd is not needed.

madebr · 2026-03-20T05:48:39Z

+#ifdef _WIN32
+		char path[32768] = { 0 };
+		DWORD length = GetModuleFileNameA(NULL, path, ARRAY_SIZE(path));
+		if (length > 0 && length < ARRAY_SIZE(path)) {
+			return std::filesystem::path(path).parent_path();
+		}
+#else
+		char path[4096] = { 0 };
+		const ssize_t length = readlink("/proc/self/exe", path, sizeof(path) - 1);
+		if (length > 0) {
+			path[length] = '\0';
+			return std::filesystem::path(path).parent_path();
+		}
+#endif


Let's also use the OPENW3D_* macros here.
For the SDL3 case, I think SDL_GetBasePath returns what we want.

/proc/self/exe only works on Linux and not on the BSDs, macOS, etc

madebr · 2026-03-20T05:51:19Z

+#ifdef _WIN32
+		std::filesystem::path appdata_path;
+		HMODULE shfolder = LoadLibraryA("shfolder.dll");
+		if (shfolder != NULL) {
+			typedef HRESULT(__stdcall *SHGetFolderPathAType)(HWND, int, HANDLE, DWORD, LPSTR);
+			SHGetFolderPathAType get_folder_path =
+				(SHGetFolderPathAType)GetProcAddress(shfolder, "SHGetFolderPathA");
+			if (get_folder_path != NULL) {
+				char path[MAX_PATH] = { 0 };
+				if (get_folder_path(NULL, CSIDL_APPDATA, NULL, 0, path) == S_OK) {
+					appdata_path = std::filesystem::path(path);
+				}
+			}
+			FreeLibrary(shfolder);
+		}
+
+		return appdata_path;
+#else
+		return std::filesystem::path();
+#endif


Same story about OPENW3D_*. SDL3 has SDL_GetUserFolder which provides what we needs.

madebr · 2026-03-20T05:52:38Z

+#ifdef _WIN32
+		std::filesystem::path config_dir = Get_Windows_AppData_Directory();
+		if (!config_dir.empty()) {
+			return config_dir / "OpenW3D" / W3D_CONF_FILENAME;
+		}
+#else
+		const char *xdg_config_home = std::getenv("XDG_CONFIG_HOME");
+		if (xdg_config_home != NULL && xdg_config_home[0] != '\0') {
+			return Make_Absolute_Path(xdg_config_home) / "OpenW3D" / W3D_CONF_FILENAME;
+		}
+
+		const char *home = std::getenv("HOME");
+		if (home != NULL && home[0] != '\0') {
+			return Make_Absolute_Path(home) / ".config" / "OpenW3D" / W3D_CONF_FILENAME;
+		}
+#endif


OPENW3d_* yada yada.

SDL_GetPrefPath returns a path for storing preferences (=configs).

…ed the Unix-specific getcwd and /proc/self/exe code, and now use SDL_GetBasePath() and SDL_GetPrefPath() for the SDL3 path cases. Get_Current_Directory() now just uses std::filesystem::current_path().

rm5248

this looks pretty reasonable to me, I don't have any concerns currently.

madebr

So happy the --gamedir option works again as designed!

I've only a small remark about the default ini location.

madebr · 2026-03-23T16:29:46Z

+		return appdata_path.empty() ? std::filesystem::path() : appdata_path / "OpenW3D";
+#elif defined(OPENW3D_SDL3)
+		char *pref_path = SDL_GetPrefPath("OpenW3D", "OpenW3D");


There's a difference between the default openw3d.conf path:

OPENRW_WIN32: C:\Users\<user>\AppData\Roaming\OpenW3D\openw3d.conf
OPENRW_SDL3: C:\Users\<user>\AppData\Roaming\OpenW3D\OpenW3D\openw3d.conf

Perhaps it should be W3DHub\OpenW3D\openw3d.conf for all?

OmniBlade

Just style nitpicks from me.

OmniBlade · 2026-03-23T23:57:24Z

+
+namespace
+{
+	constexpr char kConfigOrganization[] = "W3DHub";


This code base uses CAPS_CASE for constants and doesn't use hungarian notation for the most part.

OmniBlade · 2026-03-24T00:00:03Z

+
+	std::filesystem::path Get_User_Config_Directory()
+	{
+	#if defined(OPENW3D_WIN32)


General style in the code base is not to indent preprocessor directives and infact you didn't earlier in the file.

config: add shared openw3d.conf path handling

9a08883

caseychaos1212 requested review from OmniBlade and rm5248 March 20, 2026 05:19

madebr reviewed Mar 20, 2026

View reviewed changes

Updated helpers over to the OPENW3D_WIN32 / OPENW3D_SDL3 split, remov…

72c807d

…ed the Unix-specific getcwd and /proc/self/exe code, and now use SDL_GetBasePath() and SDL_GetPrefPath() for the SDL3 path cases. Get_Current_Directory() now just uses std::filesystem::current_path().

rm5248 approved these changes Mar 20, 2026

View reviewed changes

madebr suggested changes Mar 23, 2026

View reviewed changes

made the "openw3d.conf" default more standard

e499a51

caseychaos1212 requested a review from madebr March 23, 2026 20:39

madebr approved these changes Mar 23, 2026

View reviewed changes

OmniBlade requested changes Mar 24, 2026

View reviewed changes

Updated style to be more consistant with the code base.

adebc83

caseychaos1212 requested a review from OmniBlade March 24, 2026 03:00

OmniBlade approved these changes Mar 24, 2026

View reviewed changes

caseychaos1212 merged commit 29956ea into w3dhub:main Mar 25, 2026
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config: add shared openw3d.conf path handling and --ini override#104

config: add shared openw3d.conf path handling and --ini override#104
caseychaos1212 merged 4 commits intow3dhub:mainfrom
caseychaos1212:pr/iniconf-followup

caseychaos1212 commented Mar 20, 2026

Uh oh!

madebr Mar 20, 2026 •

edited

Loading

Uh oh!

madebr Mar 20, 2026

Uh oh!

madebr Mar 20, 2026

Uh oh!

madebr Mar 20, 2026

Uh oh!

rm5248 left a comment

Uh oh!

madebr left a comment

Uh oh!

madebr Mar 23, 2026

Uh oh!

OmniBlade left a comment

Uh oh!

OmniBlade Mar 23, 2026

Uh oh!

OmniBlade Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

caseychaos1212 commented Mar 20, 2026

Uh oh!

madebr Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madebr Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

madebr Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

madebr Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

rm5248 left a comment

Choose a reason for hiding this comment

Uh oh!

madebr left a comment

Choose a reason for hiding this comment

Uh oh!

madebr Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

OmniBlade left a comment

Choose a reason for hiding this comment

Uh oh!

OmniBlade Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

OmniBlade Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

madebr Mar 20, 2026 •

edited

Loading