Start introducing SDL3 and DXVK by madebr · Pull Request #100 · w3dhub/OpenW3D

madebr · 2026-02-21T23:30:33Z

This PR starts introducing SDL3 and DXVK by replacing win32-only function calls with abstractions on top of either win32 or SDL3.

Testing on Windows is limited.

rm5248

This looks pretty good to me, I have no real concerns.

rm5248 · 2026-02-21T23:50:14Z

+#if defined(OPENW3D_WIN32)
+#include <windows.h>
+#elif defined(OPENW3D_SDL3)
+#include <SDL3/SDL_thread.h>


any preference on using std::thread vs the SDL thread? It probably doesn't matter that much which one we use.

std::thread does not support thread priorities and, std::thread::id has an awkward way to convert to an integer (std::hash<std::thread::id>{}(std::this_thread::get_id())).

I'd prefer to use win32/SDL3, and perhaps switch later to c++ threads when we actually have the thing working on Linux: change 1 thing per commit.

Do priorities even work correctly on Linux? A process needs to have root permissions to elevate its own priority, it can only reduce them IIRC and does Renegade really make use of them? Also, why SDL3 threads rather than native pthreads which are supported pretty much everywhere none windows (except getting integer thread IDs which seems oddly platform specific)? I only ask as I've attempted to write a pthread versions previously when reversing Zero Hour https://github.com/TheAssemblyArmada/Thyme/blob/develop/src/w3d/lib/thread.cpp

posix pthreads provides a pthread_setschedprio.
It's probably used as a suggestion for the scheduler.

disclaimer: I am a SDL contributor so I am probably a bit biased.

I chose SDL3 to limit the number of dependencies as we'll already need it for creating windows and input handling. SDL uses the optimal threading libraries for each platform. Looking at SDL3's `src/thread directory, it contains implementations for n3ds, ps2, psp, pthreads, vita and windows.

I also remember this SDL timer pr wanting to replace ps2-specific code with generic code. The penalty would've been 25x.

I don't think we should reinvent the wheel here.

rm5248 · 2026-02-21T23:56:58Z

I came across this project a while ago, perhaps it would be useful for loading DLLs? What you have here is good, I'm just thinking of the future.

caseychaos1212 · 2026-02-23T21:58:34Z

+StringClass cPathUtil::GetWorkingDirectory(bool trailing_separator)
+{
+	std::error_code ec;
+	auto path = std::filesystem::current_path(ec);
+	if (!ec) {
+		path = ".";
+	}
+	if (trailing_separator) {
+		path += std::filesystem::path::preferred_separator;
+	}
+	return StringClass{path.generic_string().c_str()};
+}
+


CODEX:

Medium: Working-directory helper always collapses to ["."] on success.
[pathutil.cpp (line 9)] uses [if (!ec) path = ".";] (likely meant if (ec)), so successful current_path is discarded.

caseychaos1212

I had CODEX take a look.

Let me know if any of this is hallucinations or just missing context. It's a good learning experience for me.

OmniBlade · 2026-02-24T23:17:46Z

+#if defined(OPENW3D_WIN32)
+#include <windows.h>
+#elif defined(OPENW3D_SDL3)
+#include <SDL3/SDL_thread.h>


Do priorities even work correctly on Linux? A process needs to have root permissions to elevate its own priority, it can only reduce them IIRC and does Renegade really make use of them? Also, why SDL3 threads rather than native pthreads which are supported pretty much everywhere none windows (except getting integer thread IDs which seems oddly platform specific)? I only ask as I've attempted to write a pthread versions previously when reversing Zero Hour https://github.com/TheAssemblyArmada/Thyme/blob/develop/src/w3d/lib/thread.cpp

OmniBlade

I think sdl3 should be added to the vcpkg config as well as part of this PR, but other than that I don't have any other concerns.

…t_Thread_ID

The function measure CPU speed using win32-only functions. It's also unreliable.

madebr · 2026-03-02T16:01:14Z

I think sdl3 should be added to the vcpkg config as well as part of this PR, but other than that I don't have any other concerns.

I added sdl3 to vcpk.json.
Since DXVK requires a shared SDL3 library, I also forced usage of a shared SDL3 library.

caseychaos1212

I'm good with this.

rm5248 reviewed Feb 21, 2026

View reviewed changes

caseychaos1212 self-requested a review February 23, 2026 21:41