-
Notifications
You must be signed in to change notification settings - Fork 53
Allow for the query algorithm to return prompt
or denied
when document is not allowed to use
#458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ad of "denied" Allowing the query algorithm to return `prompt` or`denied` helps protect the user from exposing their available features and helps prevent retaliation against the user from developers.
There is some prior art at https://privacycg.github.io/storage-access/#permissions-integration and https://privacycg.github.io/requestStorageAccessFor/#permissions-integration Conceptually, WDYT @marcoscaceres, should we pull this into permissions, or just add a note saying powerful features can do this in their own permission query algorithms? |
@aselya can you elaborate a bit more on why you think exposing Permissions Policy state (which is "allowed to use") would lead to retaliation against the user? I could see an argument for why this technically exposes cross-origin information, but that seems by design, the same way that, say, the sandbox argument is observable by a cross-origin iframe. Also, that doesn't seem like something that should be implementation-defined. :) |
Ok, yeah, @johannhof is right (this has nothing to do with "allowed to use")... this needs to happen further down around... we think around step 8, where the permissions store is checked. We reviewed this and added some suggested text for the note by incorporating some of Anne's wording. |
Co-authored-by: Marcos Cáceres <[email protected]>
Apologies for the delay in response, only just saw this. I made this PR after observing that this spec and the spec for requestStorageAccessFor (rSAFor) were not in alignment on the what permission states might be returned from a query. The explanation provided in the rSAFor spec for not revealing the denied permission state seemed reasonable and worth incorporating into the permissions spec to allow for other permissions to utilize in the same manner. |
Co-authored-by: Marcos Cáceres <[email protected]>
Remove open tag that was not closed. Format text.
Move text to section 8 as requested by reviewer.
@marcoscaceres, moving the text to step 8 makes sense to me. |
@marcoscaceres @miketaylr, any additional questions preventing this merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see how this addresses #388 (comment)
In particular:
we keep this issue as a follow-up to make "permission query algorithm" run at a lower-level (or possibly not expose "denied" (do to the end user having denied) at all anymore).
I guess this note is meant to indicate user agents can do whatever, but is that really desirable?
Updated language to allow the query algorithm to return
prompt
ordenied
helps protect the user from exposing their available features and helps prevent retaliation against the user from developers.closes #388
The following tasks have been completed:
Implementation commitment:
Preview | Diff