-
Notifications
You must be signed in to change notification settings - Fork 47
[UI] Add missing properties to global configuration #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smessie
wants to merge
4
commits into
gh-pages
Choose a base branch
from
ui/global-configuration-properties
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
70a3ddd
Document shui:defaultWidgetScore in the global configuration
smessie 40adfa5
Document shui:defaultOrder in the global configuration
smessie 0c2e124
Show the two new configuration properties in the sample instance data
smessie 489ecfb
Merge branch 'gh-pages' into ui/global-configuration-properties
nicholascar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1268,6 +1268,22 @@ <h3>SHACL Global Configuration</h3> | |
| The preferred label property is determined according to the order of priority in the list from beginning (highest) to end (lowest). | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>shui:defaultWidgetScore</code></td> | ||
| <td> | ||
| The score assigned by <a href="#scoring-algorithm-scoring-graph-preparation">scoring graph preparation</a> to a widget that a shape declares with <code>shui:editor</code> or <code>shui:viewer</code> and that the scoring graph does not otherwise score. | ||
| The value of <code>shui:defaultWidgetScore</code> is of datatype <code>xsd:decimal</code> or <code>xsd:integer</code>, which are the datatypes that <code>shui:score</code> permits. | ||
| It defaults to <code>40</code>, the score conventionally used for an explicitly declared widget. | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>shui:defaultOrder</code></td> | ||
| <td> | ||
| The <a>effective order</a> assumed for <a>property shapes</a> and property groups that do not specify <code>sh:order</code>, as defined in <a href="#grouping-and-ordering">Grouping, Ordering, and Layout Hints</a>. | ||
| The value of <code>shui:defaultOrder</code> is of datatype <code>xsd:decimal</code> or <code>xsd:integer</code>, which are the datatypes that <code>sh:order</code> permits. | ||
| Where it is absent, a property shape or property group without <code>sh:order</code> has no <a>effective order</a>. | ||
| </td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| <aside class="example" title="Sample Instance Data"> | ||
|
|
@@ -1277,7 +1293,9 @@ <h3>SHACL Global Configuration</h3> | |
| shui:defaultNamespace "http://example.com/ns#" ; | ||
| shui:languagePreference ("" "en" "de") ; | ||
| shui:timeZone "Europe/Vienna" ; | ||
| shui:labelPreference (skos:prefLabel dcterms:title rdfs:label) . | ||
| shui:labelPreference (skos:prefLabel dcterms:title rdfs:label) ; | ||
| shui:defaultWidgetScore 40 ; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove that part. See #1195 |
||
| shui:defaultOrder 0 . | ||
| </div> | ||
| </div> | ||
| </p> | ||
|
|
@@ -1513,11 +1531,6 @@ <h3>Scoring Graph Preparation</h3> | |
| </div> | ||
| </div> | ||
| </aside> | ||
| <p class="ednote"> | ||
| The <a>global configuration</a> is defined by | ||
| <a href="https://github.com/w3c/data-shapes/pull/900">PR #900</a>, which is not merged yet. | ||
| Add `shui:defaultWidgetScore` to its property table once it is. | ||
| </p> | ||
| <p class="note"> | ||
| Scoring graph preparation depends only on the <strong>shapes graph</strong> and the <strong>scoring graph</strong>, | ||
| not on a focus node or a shape node. It is therefore the same for every call of the score function over those two | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove that part. See #1195
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially thought this wasn't related to the referenced PR, but it turns out it is.
The core question here is: Do we want a
shui:defaultWidgetScorethat applies when no scoring shapes are added to a widget? Why would we need scoring shapes here? This situation was actually introduced by the merged PR.To recap what that PR changed:
shui:editorandshui:vieweris still supported.scoreandselectfunctions had to return either a single IRI (ifbestwastrue) or an array ofScoreResults. This was difficult to implement, hard to read, and led to maintainability concerns. We restructured this to align with the task force’s overall vision. Also slect and score did not differ a lot from each other, but were different enough to need two functions.It seems @bergos wants the ability to hardcode widgets without relying on the scoring system. These differing architectural viewpoints are currently blocking progress across multiple issues.
Proposal: Before proceeding further, let's explicitly resolve the core architectural questions regarding spec functionality, conformance, and whether we are targeting a single normative core or supporting multiple profiles as that is at the heart of this issue.