#1113: Moved SHACL-SPARQL Rules section into its own shacl12-inference-rules document - #1186
#1113: Moved SHACL-SPARQL Rules section into its own shacl12-inference-rules document#1186HolgerKnublauch wants to merge 27 commits into
Conversation
|
I wonder if Sections 11 - SPARQL Rules & 12 - Triple Rules can be collapsed down into subsections within a Section 11 - Rule Types? This will better match with Section 2's examples of Rule Types. I don't have a comment on the changes needed for publication yet. |
There are arguments in both directions. I see Triple Rules as sufficiently distinct from SPARQL rules to go into their own top-level section. But I don't mind either way. If anyone else supports this change, I'll do it. |
Oh yes, I recognise they are entirely distinct but by putting the SPARQL & Triple rule types in a Rule Types section, their distinction is preserved but it just emphasises their being part of an (open ended) set of potential rule types. |
Ok I have moved them into a shared section "Built-in Rule Types" now. This had the added benefit of forcing me to think about compliance. I have added a sentence that engines must report a failure when they encounter unknown rule types. I hope this allows us to proceed for this first version. |
|
This would be a good time to rename shacl12-sparql as "SHACL SPARQL-based extensions" |
|
This does not close #1113. There is no decision on whether there is a separate top rules doc. |
Co-authored-by: Andy Seaborne <andy@apache.org>
Right, that topic was a spin-off from the #1113 thread so I have moved it to its own ticket #1196. It shouldn't hold off moving SHACL rules into its own document. |
|
This PR makes some unrelated changes SHACL SPARQL(-based) Extensions. |
mgberg
left a comment
There was a problem hiding this comment.
Looks good to me, although I'm not 100% sure what Andy's last comment is referring to.
e.g. sh:sparqlExpr around L1674 is a name change. shacl-node-expr has a spelling correction. |
Yes intentional, some of these were detected with Claude and are IMHO bug fixes and non-substantial changes. If you can live with those, it would be great if you could remove the Request Changes tag. |
I indeed completely missed that comment. yes please! thanks a lot |
Co-authored-by: simon <simon.steyskal@siemens.com>
Co-authored-by: simon <simon.steyskal@siemens.com>
Co-authored-by: simon <simon.steyskal@siemens.com>
Co-authored-by: simon <simon.steyskal@siemens.com>
Co-authored-by: simon <simon.steyskal@siemens.com>
Co-authored-by: simon <simon.steyskal@siemens.com>
Co-authored-by: simon <simon.steyskal@siemens.com>
|
Holger asked: "why you are still blocking it" My suggestions are from July 15 when the SHACL-AF material was placed in SHACL SPARQL. Documents are not always read top to bottom - people jump to relevant sections. I think first use in any substantial body of content makes it clearer to the reader - and machines - at no cost by using the proper name and by linking. The document work involved is minimal. Definition and section title proper names are a minimum. |
Co-authored-by: Andy Seaborne <andy@apache.org>
|
@afs I have applied your suggestions. Please review again. Note that this PR was meant to be entirely editorial, to cut and paste the rules section from SHACL-SPARQL into a stand-alone document. I have tried to avoid making too many other changes, in part because it's difficult to track them in the change history. While some clean-up of terminology is fine, I don't think that using the blocking Request Changes was an appropriate process in this case. |
Closes #1113
See the new Inference Rules document rendered online here
See the new remaining SPARQL document rendered online here
I basically moved the Rules section without changing semantics. A few editorial improvements were made on this opportunity.
There is a broken reference to shacl12-inference-rules from the SPARQL document right now, which I hope will disappear once the new document has been published.
@nicholascar @caribouW3 do I need to change anything so that the new document can be published?
@simonstey you were one of the editors of the SHACL-AF document and I believe you deserve either to be included as one of the authors of Inference Rules, or be mentioned as former editor. Please let me know your preference. Happy to add you as author if you can still identify with the content :)