Add new environment settings object field "cross site ancestry" for SameSite cookies work #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/html#9000 for the broader context
yoshisatoyanagisawa
approved these changes
Jun 9, 2025
annevk
reviewed
Jul 24, 2025
annevk
reviewed
Jul 25, 2025
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Jul 25, 2025
This helps with the HTTP WG's layered cookies draft integration work. whatwg/fetch#1807 depends on this state being available in so we can define SameSite properly. Corresponding Service Worker PR: w3c/ServiceWorker#1775.
This reverts commit e44219a.
|
whatwg/html#11133 looks merged. |
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Aug 1, 2025
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To define how cookies work correctly, particularly around the SameSite attribute, we need to know whether or not an environment settings object has any cross-site ancestors. This is making sure the ESO definition in ServiceWorkers also defines this member algorithm.
We will have to land the PR that adds this to HTML before landing this, but it'd be nice to get this approved before we alter HTML so everything goes smoothly.
See whatwg/html#9000 for even broader context.
Preview | Diff