fix(benchmark): run typedframes checker against actual corpus#19
Merged
Conversation
…rdcoded example file
This was referenced May 16, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…fter copy Cloning to a persistent path in BENCH_DIR left a large directory in /tmp between runs. Switch to tempfile.mkdtemp() and rmtree in a finally block so the clone is always removed once its contents have been copied out.
…corrected corpus - generate_markdown_table now omits rows where all runs failed (e.g. pyright not installed), so the README never shows "Tool not found" cells - Re-run with the corrected benchmark (typedframes now targets the full corpus rather than a single example file); great_expectations column updated from the invalid 930µs to the actual 310ms ±10ms
npx is not universally available; pyright is already in the dev dependency group so uv run pyright works everywhere the dev env is installed. Re-run includes pyright numbers: 822ms (13 files), 3.43s (488 files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv run typedframes check) so the benchmark targets the actual corpus directory rather than a single hardcoded example filefind_binaryhelper andbinary_pathparametertempfile.mkdtemp()dir and removes it after copying, so no large directory is left behind in/tmpStacked on #18 (cache-clearing path fixes) — target that branch, not main.
Test plan
run_codebase_benchmarksno longer special-cases typedframesuv run typedframes checkas its command