Draft
Conversation
f669505 to
429d906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inpaint_with_mask.Validation
/opt/homebrew/bin/python3.11 -m pytest tests/test_mask_refine.py tests/test_layers_redraw.py tests/test_layers_redraw_crop_pipeline.py tests/test_layers_redraw_mask_aware.py tests/test_layers_redraw_quality_gates.py tests/test_layers_redraw_refinement.py tests/test_layers_redraw_strategy.py tests/test_layers_redraw_wire_contract.py tests/test_layers_v2_redraw.py tests/test_mcp_layers_redraw_advisory.py tests/test_redraw_review_contract.py tests/test_redraw_showcase_review.py tests/test_gemini_image_size.py tests/test_provider_edit_capabilities.py->143 passed, 5 warningsgit diff --check-> passedroute_chosen=inpaint,refinement_applied=true,provider_requires_mask_for_edits=true,raw_scene_rejected=false, output alpha0.0249%of canvas, bbox(2627, 1484, 2700, 1549).Visual Risk
This is a provider-adapter quality improvement, not a full visual finish. The latest NB2 output no longer contaminates broad grass/vehicle regions and is localized to the flower footprint, but it can still render a chunky yellow patch because Gemini is not a native alpha-mask edit endpoint. Further work should tune scale/alpha extraction or use a provider with native masked edits for final showcase evidence.
Stacking
Stacked on PR #42 (
codex/v0-23-redraw-replacement-contract). Keep this draft until #42 lands or retarget after merge.