Skip to content

feat(vscode): conservatively modify formatting ranges #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnsoncodehk merged 1 commit into from
Dec 11, 2025
Merged

feat(vscode): conservatively modify formatting ranges #5851

johnsoncodehk merged 1 commit into from
Dec 11, 2025

Conversation

@johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Dec 11, 2025 •
edited
Loading

This PR changes the behavior from #5849:

  • Both are non-whitespace but different → advance both (1:1 replacement)

New behavior:

  • Both are non-whitespace but different → stop scanning, treat the current position as the final modify boundary.

@johnsoncodehk johnsoncodehk merged commit a8a758a into master Dec 11, 2025
13 checks passed
@johnsoncodehk johnsoncodehk deleted the format-range branch December 11, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnsoncodehk