Repository navigation
Add support for retrieving newer txs only - #216
Draft
everoddandeven wants to merge 1 commit into
Draft
everoddandeven wants to merge 1 commit into
everoddandeven wants to merge 1 commit into
Conversation
everoddandeven
force-pushed
the
v2/get-address-txs
branch
from
December 12, 2025 15:34
9e7d829 to
3ca188f
Compare
Owner
|
I realized this is a work-in-progress, but the database change isn't going to work unless there is migration code to handle it. The existing migration examples aren't going to work either, as those only work with appending values to |
vtnerd
reviewed
Dec 13, 2025
| crypto::hash tx_hash; //!< Hash of the transaction | ||
| block_id height; //!< Block height containing transaction | ||
| crypto::hash tx_hash; //!< Hash of the transaction | ||
| crypto::hash block_hash; //!< Hash of the block |
Owner
There was a problem hiding this comment.
Another quick review - this shouldn't be needed as the db already stores hashes. If the hash is before a checkpoint, and therefore not stored, then reorg protection isn't needed ...
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.