Keep Cypress E2E running past a storefront SyntaxError - #12
Open
chrsmutti wants to merge 6 commits into
Open
Conversation
Cypress 8 was aborting every spec on a malformed recsys snippet in the biggy HTML, and the remaining assertions were tied to 2022 product and facet numbers. Daily E2E now posts failures to Slack via the repo webhook secret. Co-authored-by: Cursor <cursoragent@cursor.com>
🛡️ SDD Check — action requiredI couldn't detect an SDD in this PR. Please check one option below (requires write access to the repo):
|
GitHub now fails workflows that still use cache v1/v2, which blocked lint and IO app test on this PR. Co-authored-by: Cursor <cursoragent@cursor.com>
The missing-application-id gate needs referenceId on the deployment file, and Danger requires an Unreleased changelog entry. Co-authored-by: Cursor <cursoragent@cursor.com>
chrsmutti
requested review from
ArthurFerrao,
LucasTornai,
felipe-fg and
thiagopereira-vtex
August 25, 2026 19:44
Co-authored-by: Cursor <cursoragent@cursor.com>
…deps. Self-hosted images do not ship yarn or Cypress' system libraries, unlike the GitHub-hosted ones. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The biggy storefront HTML injects a recsys snippet whose API key is interpolated away. That leaves an unterminated string and Cypress 8 fails every spec in
before():That happens with
VTEX_WORKSPACE=chrs,master, and no workspace, so it is not a linked-app issue. After ignoring only that exception, the specs still failed on 2022 catalog counts, stale selectors, andvisitPath()buildinghttp://URLs against an HTTPSbaseUrl.How to test it?
Both suites passed locally at 29/29 after these changes (Electron).
Daily E2E (after merge to
main): Actions → Daily Cypress E2E → Run workflow. Failures post to#search-personalization-alertsvia theSLACK_WEBHOOKrepo secret (Slack workflow trigger). A test event was already delivered to that channel.Workspace
Screenshots or example usage:
Ignored storefront exception (narrow match only):
Full-text search used to require exactly 3 gallery items; the page now shows 8 organic products plus sponsored tiles. The spec now checks that results exist and the reported total is > 0.
Describe alternatives you've considered, if any.
Fixing the recsys snippet on the storefront would be the real root-cause fix. This repo can only keep E2E from aborting on that app exception.
Related to / Depends on
Repo secret
SLACK_WEBHOOKis already set onvtex/search-tests. The daily workflow Slack variables arestatus,text, andrun_url.How does this PR make you feel? 🔗
Made with Cursor