EDU-16477: Data Plane API (CMS)#1650
Open
mariana-caetano wants to merge 2 commits intomasterfrom
Open
Conversation
|
Thanks for your contribution. The .json file will be checked now with Spectral. |
| "Entry" | ||
| ], | ||
| "summary": "List entries by content type", | ||
| "description": "Lists entries for a content type and store, with optional sorting, pagination cursor, and locale-aware content resolution.\r\n\r\n## Permissions\r\n\r\nThis endpoint does not require [License Manager resources](https://help.vtex.com/en/tutorial/license-manager-resources--3q6ztrC8YynQf6rdc6euk3).", |
There was a problem hiding this comment.
@vitorflg @victorhmp Once we introduce GraphQL, is the expectation to remove the SORT feature? If so, we should exclude it from the documentation.
| "name": "contentTypeId", | ||
| "in": "path", | ||
| "description": "Content type identifier.", | ||
| "required": true, |
There was a problem hiding this comment.
@vitorflg @victorhmp For this API: Get entry by Slug, why are we requiring the content type ID, in addition to the Slug? I thought we only required the Slug. Is this a mismatch of functionality vs. documentation?
There was a problem hiding this comment.
It doesn't make sense to make the ID required in this case. My expectation is that only slug is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Changelog
Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?