chore: test next-logger with pino#2973
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThis PR adds instrumentation and logging support to FastStore core by enabling Next.js's experimental instrumentation hook, adding the Pino logging dependency, and implementing a conditional registration function that loads Pino and next-logger in production Node.js environments outside of Vercel. ChangesInstrumentation Setup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 39 minutes and 56 seconds.Comment |
@faststore/api
@faststore/cli
@faststore/components
@faststore/core
@faststore/graphql-utils
@faststore/lighthouse
@faststore/sdk
@faststore/ui
commit: |
32d5700 to
ccecd25
Compare
…larity - Introduced boolean variables for runtime checks: isNodeRuntime, isProduction, and isVercel. - Updated the conditional logic in the register function to enhance readability and maintainability.
- Updated "@faststore/core", "@faststore/graphql-utils", and "@faststore/lighthouse" to version 3.99.0-dev.4 in pnpm-lock.yaml. - Updated "next-logger" to version 5.0.2 in package.json. - Adjusted peer dependencies and integrity checks accordingly.
- Simplified the runtime checks by removing unnecessary boolean variables. - Enhanced readability by directly using environment variables in the conditional statements.
What's the purpose of this pull request?
This pull request introduces instrumentation and logging enhancements to the
corepackage, primarily enabling experimental instrumentation hooks in Next.js and conditionally loading logging libraries in production node environments.References
https://vercel.com/docs/environment-variables/system-environment-variables#VERCEL
https://nextjs.org/docs/app/guides/instrumentation
https://nextjs.org/docs/app/api-reference/file-conventions/instrumentation